Bug 967334
| Summary: | Review Request: rubygem-connection_pool - Generic connection pool for Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedoraparked |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | axilleas, package-review, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-08 04:40:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
fedoraparked
2013-05-26 17:23:47 UTC
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-connection_pool/mock rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. I taking this for a review. * Summary
- The summary is quite brief. Would you mind to add more details, e.g.
something from beginning of README
* pushd .%{gem_instdir}
- In the %check section, could you please replace the "pushd ." with more
accurate "pushd .%{gem_instdir}"? Although in this case, it works quite ok,
it would fails, if the gem contains binary extension, since now you are
testing the unpacked gem, instead of installed gem.
* Move README.md into -doc subpackage
- I prefer to put all files not needed for runtime into -doc subpackage.
However, this is my personal preference, so it is up to you.
* Keep Gemfile and Rakefile in -doc subpackage
- Although these files are not needed for Fedora, I prefer to keep them in
-doc subpackage as long as they are shipped by upstream. Nevertheless, this
is not blocker.
Nevertheless, the above are just minor fix so I APPROVE the package, but please fix the issues prior import into Fedora.
Done. Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool-1.0.0-2.fc19.src.rpm Since this package is already approved, I am flagging this for fedora-cvs. New Package SCM Request ======================= Package Name: rubygem-connection_pool Short Description: Generic connection pool for Ruby Owners: anujmore axilleas Branches: f19 InitialCC: Git done (by process-git-requests). |