Bug 967334 - Review Request: rubygem-connection_pool - Generic connection pool for Ruby
Summary: Review Request: rubygem-connection_pool - Generic connection pool for Ruby
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-26 17:23 UTC by Anuj More
Modified: 2014-03-08 04:40 UTC (History)
3 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2014-03-08 04:40:34 UTC
vondruch: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Anuj More 2013-05-26 17:23:47 UTC
Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool.spec
SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool-1.0.0-1.fc19.src.rpm
Description: Generic connection pool for Ruby
Fedora Account System Username: anujmore

Comment 1 Anuj More 2013-05-26 17:34:16 UTC
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-connection_pool/mock
rpmlint does not complain: 
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Vít Ondruch 2013-06-04 13:09:04 UTC
I taking this for a review.

Comment 3 Vít Ondruch 2013-06-04 14:06:15 UTC
* Summary
  - The summary is quite brief. Would you mind to add more details, e.g.
    something from beginning of README

* pushd .%{gem_instdir}
  - In the %check section, could you please replace the "pushd ." with more
    accurate "pushd .%{gem_instdir}"? Although in this case, it works quite ok,
    it would fails, if the gem contains binary extension, since now you are
    testing the unpacked gem, instead of installed gem.

* Move README.md into -doc subpackage
  - I prefer to put all files not needed for runtime into -doc subpackage.
    However, this is my personal preference, so it is up to you.

* Keep Gemfile and Rakefile in -doc subpackage
  - Although these files are not needed for Fedora, I prefer to keep them in
    -doc subpackage as long as they are shipped by upstream. Nevertheless, this
    is not blocker.

Nevertheless, the above are just minor fix so I APPROVE the package, but please fix the issues prior import into Fedora.

Comment 4 Anuj More 2013-08-04 07:11:02 UTC
Done.

Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool.spec
SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool-1.0.0-2.fc19.src.rpm

Since this package is already approved, I am flagging this for fedora-cvs.

Comment 5 Anuj More 2013-08-04 07:13:14 UTC
New Package SCM Request
=======================
Package Name: rubygem-connection_pool
Short Description: Generic connection pool for Ruby
Owners: anujmore axilleas
Branches: f19
InitialCC:

Comment 6 Gwyn Ciesla 2013-08-05 12:21:11 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.