Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool-1.0.0-1.fc19.src.rpm Description: Generic connection pool for Ruby Fedora Account System Username: anujmore
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-connection_pool/mock rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
I taking this for a review.
* Summary - The summary is quite brief. Would you mind to add more details, e.g. something from beginning of README * pushd .%{gem_instdir} - In the %check section, could you please replace the "pushd ." with more accurate "pushd .%{gem_instdir}"? Although in this case, it works quite ok, it would fails, if the gem contains binary extension, since now you are testing the unpacked gem, instead of installed gem. * Move README.md into -doc subpackage - I prefer to put all files not needed for runtime into -doc subpackage. However, this is my personal preference, so it is up to you. * Keep Gemfile and Rakefile in -doc subpackage - Although these files are not needed for Fedora, I prefer to keep them in -doc subpackage as long as they are shipped by upstream. Nevertheless, this is not blocker. Nevertheless, the above are just minor fix so I APPROVE the package, but please fix the issues prior import into Fedora.
Done. Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-connection_pool/rubygem-connection_pool-1.0.0-2.fc19.src.rpm Since this package is already approved, I am flagging this for fedora-cvs.
New Package SCM Request ======================= Package Name: rubygem-connection_pool Short Description: Generic connection pool for Ruby Owners: anujmore axilleas Branches: f19 InitialCC:
Git done (by process-git-requests).