Bug 967335

Summary:	Review Request: rubygem-dotenv - Loads environment variables from `.env`
Product:	[Fedora] Fedora	Reporter:	fedoraparked
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	axilleas, notting, vondruch
Target Milestone:	---	Flags:	vondruch: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-dotenv-0.8.0-2.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-08 23:27:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description fedoraparked 2013-05-26 17:23:50 UTC

Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-dotenv/rubygem-dotenv.spec
SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-dotenv/rubygem-dotenv-0.7.0-1.fc19.src.rpm
Description: Loads environment variables from `.env`
Fedora Account System Username: anujmore

Comment 1 fedoraparked 2013-05-26 17:34:19 UTC

Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-dotenv/mock
rpmlint does not complain: 
rubygem-dotenv.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy
rubygem-dotenv.noarch: W: spelling-error %description -l en_US env -> enc, en, envy
rubygem-dotenv.src: W: spelling-error Summary(en_US) env -> enc, en, envy
rubygem-dotenv.src: W: spelling-error %description -l en_US env -> enc, en, envy
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Nothing wrong with "env".

Comment 2 Vít Ondruch 2013-06-11 05:25:16 UTC

I'll take this for a review.

Comment 3 Vít Ondruch 2013-06-11 05:52:57 UTC

* Run the test suite in .%{gem_instdir}
  - Could you please run the test suite on installed gem, i.e. inside
    .%{gem_instdir}. If the gem is binary, you would be missing the compiled
    extension.

* Keep .gemspec, Gemfile, Guardfile and Rakefile in -doc subpackage
  - This is up to you, but I would keep these files in -doc subpackage.
  - Alternatively, you could suggest upstream to drop them from the package,
    since they are not overly useful in distributed gem.
  - Actually, since we are there, I would question upstream about purpose of
    dotenv-rails.gemspec and the file lib/dotenv-rails. It seems that this
    should not be included at all?

Neither of these are blockers, so I APPROVE the package. However, please consider to fix this nits prior importing this package into Fedora.

Comment 4 fedoraparked 2013-08-04 07:01:22 UTC

Package Name: rubygem-dotenv
Short Description: Loads environment variables from `.env`
Owners: anujmore axilleas
Branches: f19

Comment 5 fedoraparked 2013-08-04 07:12:35 UTC

New Package SCM Request
=======================
Package Name: rubygem-dotenv
Short Description: Loads environment variables from `.env`
Owners: anujmore axilleas
Branches: f19
InitialCC:

Comment 6 Gwyn Ciesla 2013-08-05 12:21:57 UTC

Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-08-31 06:51:40 UTC

rubygem-dotenv-0.8.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-dotenv-0.8.0-2.fc19

Comment 8 Fedora Update System 2013-08-31 23:56:35 UTC

rubygem-dotenv-0.8.0-2.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-09-08 23:27:36 UTC

rubygem-dotenv-0.8.0-2.fc19 has been pushed to the Fedora 19 stable repository.