Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-dotenv/rubygem-dotenv.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-dotenv/rubygem-dotenv-0.7.0-1.fc19.src.rpm Description: Loads environment variables from `.env` Fedora Account System Username: anujmore
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-dotenv/mock rpmlint does not complain: rubygem-dotenv.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy rubygem-dotenv.noarch: W: spelling-error %description -l en_US env -> enc, en, envy rubygem-dotenv.src: W: spelling-error Summary(en_US) env -> enc, en, envy rubygem-dotenv.src: W: spelling-error %description -l en_US env -> enc, en, envy 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Nothing wrong with "env".
I'll take this for a review.
* Run the test suite in .%{gem_instdir} - Could you please run the test suite on installed gem, i.e. inside .%{gem_instdir}. If the gem is binary, you would be missing the compiled extension. * Keep .gemspec, Gemfile, Guardfile and Rakefile in -doc subpackage - This is up to you, but I would keep these files in -doc subpackage. - Alternatively, you could suggest upstream to drop them from the package, since they are not overly useful in distributed gem. - Actually, since we are there, I would question upstream about purpose of dotenv-rails.gemspec and the file lib/dotenv-rails. It seems that this should not be included at all? Neither of these are blockers, so I APPROVE the package. However, please consider to fix this nits prior importing this package into Fedora.
Package Name: rubygem-dotenv Short Description: Loads environment variables from `.env` Owners: anujmore axilleas Branches: f19
New Package SCM Request ======================= Package Name: rubygem-dotenv Short Description: Loads environment variables from `.env` Owners: anujmore axilleas Branches: f19 InitialCC:
Git done (by process-git-requests).
rubygem-dotenv-0.8.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-dotenv-0.8.0-2.fc19
rubygem-dotenv-0.8.0-2.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-dotenv-0.8.0-2.fc19 has been pushed to the Fedora 19 stable repository.