Bug 969212
| Summary: | Review Request: x2goclient - Graphical client for use with the X2Go network based computing environment | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, leamas.alec, mail, notting, pahan, samuel-rhbugs |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | x2goclient-4.0.1.1-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-22 23:49:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 969209, 1004951 | ||
| Bug Blocks: | 998551 | ||
|
Description
Orion Poplawski
2013-05-30 22:06:38 UTC
*** Bug 550277 has been marked as a duplicate of this bug. *** Just a drive-by comment: the iconcache scriptlets and desktop-file-validate are missing, just as for pyhoca-gui. Here are build errors on rawhide:
Traceback (most recent call last):
File "setup.py", line 37, in <module>
from setuptools import setup, find_packages
ImportError: No module named setuptools
Missing BR:...
Also, the qtbrowserplugin contains seems to contain BSD-licensed code. Unless not shipped, this affects the license.
Built, installed, runs, but connection failed, "x2golistsessions: command not found" Built it ok on F18, I guess Jon built on F19. My errors was from a F20/rawhide build in mock (In reply to Alec Leamas from comment #3) > Here are build errors on rawhide: > > Traceback (most recent call last): > File "setup.py", line 37, in <module> > from setuptools import setup, find_packages > ImportError: No module named setuptools > > Missing BR:... I think you have the wrong package - no setup.py here... > Also, the qtbrowserplugin contains seems to contain BSD-licensed code. > Unless not shipped, this affects the license. Nope: https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F but I do need to file for a bundling exception. (In reply to Jon Ciesla from comment #4) > Built, installed, runs, but connection failed, "x2golistsessions: command > not found" Are you connecting to an x2goserver instance? It's not expected to be able to connect to a regular nx server. Ah, no, I was attempting a connection to a freenx server. I've filed https://fedorahosted.org/fpc/ticket/343 to make it official, but I have found any way to provide qtbrowserplugin as a separate library yet so I think it needs to remain "bundled". http://www.cora.nwra.com/~orion/fedora/nx/x2goclient.spec http://www.cora.nwra.com/~orion/fedora/nx/x2goclient-4.0.1.0-4.fc18.src.rpm * Fri Aug 30 2013 Orion Poplawski <orion.com> - 4.0.1.0-4 - Add BR desktop-file-utils and validate desktop file - Add gtk-update-icon-cache scriptlets I think you meant http://www.cora.nwra.com/~orion/fedora/nx/x2goclient-4.0.1.0-4.fc19.src.rpm Looking at that now. - rpmlint checks return: Clean. What is this black magic? - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2+ correct as stated above) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So once the bundling exception is resolved, you're good to go. http://www.cora.nwra.com/~orion/fedora/nx/x2goclient.spec http://www.cora.nwra.com/~orion/fedora/nx/x2goclient-4.0.1.0-5.fc19.src.rpm * Thu Sep 5 2013 Orion Poplawski <orion.com> - 4.0.1.0-5 - Build against system qtbrowserplugin Builds and runs with qtbrowserplugin review version. APPROVED. Thanks! New Package SCM Request ======================= Package Name: x2goclient Short Description: Graphical client for use with the X2Go network based computing environment Owners: orion Branches: f20 f19 f18 el6 InitialCC: Git done (by process-git-requests). x2goclient-4.0.1.0-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/x2goclient-4.0.1.0-5.fc20 x2goclient-4.0.1.0-5.fc20 has been pushed to the Fedora 20 testing repository. x2goclient-4.0.1.1-1.fc20 has been pushed to the Fedora 20 testing repository. x2goclient-4.0.1.1-1.fc20 has been pushed to the Fedora 20 stable repository. |