Bug 970436
Summary: | Review Request: mingw-kde-filesystem - KDE filesystem layout | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steve <ulatekh> |
Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | msuchy, package-review |
Target Milestone: | --- | Flags: | msuchy:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-01-07 13:25:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449, 970438 |
Description
Steve
2013-06-04 03:28:27 UTC
Please use macros consistently I.e. instead of $RPM_BUILD_ROOT please use %{buildroot}. %defattr(-,root,root,-) This is not needed since rpm 4.2 mingw-kde-filesystem.spec:182: W: mixed-use-of-spaces-and-tabs (spaces: line 64, tab: line 182) > # teamnames (locales) borrowed from kde-i18n packaging > Source1: teamnames Do you use it somewhere. It seems to me, that it is not used at all. The same goes for: > Source2: macros.kde4 And then you are creating dynamically cat >$RPM_BUILD_ROOT%{mingw32_sysconfdir}/rpm/macros.kde4<<EOF So I would suggest to put your content in macros.kde4 which you include as SourceX and the just do: cp -a macros.kde4 %{buildroot}%{mingw32_sysconfdir}/rpm/macros.kde4 Ping! Any progress? Still no progress. Closing for now. If you ever want to continue, feel free to reopen this bug or file new one. |