Bug 970436 - Review Request: mingw-kde-filesystem - KDE filesystem layout
Review Request: mingw-kde-filesystem - KDE filesystem layout
Status: CLOSED DEFERRED
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Miroslav Suchý
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW 970438
  Show dependency treegraph
 
Reported: 2013-06-03 23:28 EDT by Steve
Modified: 2016-01-07 08:25 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-01-07 08:25:19 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
msuchy: fedora‑review?


Attachments (Terms of Use)

  None (edit)
Description Steve 2013-06-03 23:28:27 EDT
Spec URL: https://www.box.com/s/oynq8j01fzcmpt8fwjxq
SRPM URL: https://www.box.com/s/oms01ttdehwg835zvppu
Description: This package provides some directories that are required/used by KDE.
This is the MinGW version of a package that Fedora already has in its repository.
Fedora Account System Username: ulatekh
Comment 1 Miroslav Suchý 2015-08-17 09:25:26 EDT
Please use macros consistently
I.e. instead of $RPM_BUILD_ROOT please use %{buildroot}.

%defattr(-,root,root,-)
This is not needed since rpm 4.2

mingw-kde-filesystem.spec:182: W: mixed-use-of-spaces-and-tabs (spaces: line 64, tab: line 182)

> # teamnames (locales) borrowed from kde-i18n packaging
> Source1: teamnames

Do you use it somewhere. It seems to me, that it is not used at all.

The same goes for:
> Source2: macros.kde4

And then you are creating dynamically
cat >$RPM_BUILD_ROOT%{mingw32_sysconfdir}/rpm/macros.kde4<<EOF

So I would suggest to put your content in macros.kde4 which you include as SourceX and the just do:
cp -a macros.kde4 %{buildroot}%{mingw32_sysconfdir}/rpm/macros.kde4
Comment 2 Miroslav Suchý 2015-10-01 06:26:58 EDT
Ping! Any progress?
Comment 3 Miroslav Suchý 2016-01-07 08:25:19 EST
Still no progress. Closing for now. If you ever want to continue, feel free to reopen this bug or file new one.

Note You need to log in before you can comment on or make changes to this bug.