Bug 971204

Summary:	REST API changes can potentially break clients, need to avoid changing an existing attribute
Product:	OpenShift Online	Reporter:	Clayton Coleman <ccoleman>
Component:	Master	Assignee:	Lili Nader <lnader>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	jhou, jliggitt, mfisher, xtian, zzhao
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-24 14:51:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Clayton Coleman 2013-06-06 01:56:22 UTC

Given that most requests to /broker/rest/api are not version qualified, we cannot change the type of the "versions" value from string to float.

We should introduce a new attribute "api_version" which is a float and leave "version" as a string (in API >= 1.5).

Blocks release

Comment 1 Jordan Liggitt 2013-06-07 16:09:16 UTC

Will our API version always be able to be expressed as a float? e.g. no more than one point version?

Comment 2 Clayton Coleman 2013-06-12 14:43:09 UTC

We cannot exit this sprint with this issue.

Comment 3 Lili Nader 2013-06-14 19:14:24 UTC

https://github.com/openshift/origin-server/pull/2851

Comment 4 openshift-github-bot 2013-06-17 21:29:48 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/8c69ff884f23bb9226ce32be8211b28735b3baf5
Bug 971204

Comment 5 zhaozhanqi 2013-06-18 10:00:45 UTC

Tested this issue on devenv_3373, it has been fixed.


             <type>string</type>
              <description>The key portion of an rsa key (excluding ssh-rsa and comment)</description>
              <valid-options/>
              <invalid-options/>
            </param>
          </required-params>
          <optional-params/>
        </link>
      </links>
    </user>
  </data>
  <messages/>
  <version>1.5</version>
  <api-version>1.5</api-version>
  <supported-api-versions>
    <supported-api-version>1.0</supported-api-version>
    <supported-api-version>1.1</supported-api-version>
    <supported-api-version>1.2</supported-api-version>
    <supported-api-version>1.3</supported-api-version>
    <supported-api-version>1.4</supported-api-version>
    <supported-api-version>1.5</supported-api-version>
  </supported-api-versions>
</response>