Bug 972672

Summary: Package does not run rm -rf %{buildroot} : false positive
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: fedora-reviewAssignee: Stanislav Ochotnicky <sochotni>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: leamas.alec, pingou, sochotni
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: fedora-review-0.5.0-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-30 13:20:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Remi Collet 2013-06-10 11:41:52 UTC
All PEAR package must contains
  rm -rf %{buildroot}%{pear_metadir}/.??*

This command raise a false positive

[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required

Comment 1 Alec Leamas 2013-06-10 11:50:19 UTC
Hm... with rpmbuild automatically taking care of removing %{buildroot} as required, isn't the requirement above for PEAR packages outdated?

Comment 2 Alec Leamas 2013-06-10 11:52:31 UTC
oops... that's  %{buildroot}%{pear_metadir}, sorry.

This indeed looks like a bug, the search pattern should be restricted somehow. Do you have a testcase (spec file, review request)?

Comment 3 Remi Collet 2013-06-10 11:52:52 UTC
No, this command is required.

This line is not the first of %install, 
but the last one (cleanup after the main install of unneeded metadata).

Comment 4 Alec Leamas 2013-07-09 11:47:39 UTC
Fixed in devel: https://fedorahosted.org/FedoraReview/changeset/431e43f971843584f5e9f1b7d1fe260916bd21ca

Thanks for this report!

Comment 5 Fedora Update System 2013-08-30 13:12:51 UTC
fedora-review-0.5.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/fedora-review-0.5.0-1.el6

Comment 6 Fedora Update System 2013-08-30 13:13:19 UTC
fedora-review-0.5.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/fedora-review-0.5.0-1.fc19

Comment 7 Alec Leamas 2013-08-30 13:20:38 UTC
Closing bug with new 0.5.0 release. Please feel free to reopen if problem should persist. Thanks again for reporting!

Comment 8 Fedora Update System 2013-09-01 23:05:00 UTC
fedora-review-0.5.0-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2013-09-16 17:43:30 UTC
fedora-review-0.5.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.