Hide Forgot
All PEAR package must contains rm -rf %{buildroot}%{pear_metadir}/.??* This command raise a false positive [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required
Hm... with rpmbuild automatically taking care of removing %{buildroot} as required, isn't the requirement above for PEAR packages outdated?
oops... that's %{buildroot}%{pear_metadir}, sorry. This indeed looks like a bug, the search pattern should be restricted somehow. Do you have a testcase (spec file, review request)?
No, this command is required. This line is not the first of %install, but the last one (cleanup after the main install of unneeded metadata).
Fixed in devel: https://fedorahosted.org/FedoraReview/changeset/431e43f971843584f5e9f1b7d1fe260916bd21ca Thanks for this report!
fedora-review-0.5.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.5.0-1.el6
fedora-review-0.5.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.5.0-1.fc19
Closing bug with new 0.5.0 release. Please feel free to reopen if problem should persist. Thanks again for reporting!
fedora-review-0.5.0-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.