Bug 973584

Summary: Lightdm leaks 6 FDs
Product: [Fedora] Fedora Reporter: Rumen B. <rumen>
Component: lightdmAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 19CC: christoph.wickert, dan.mashal, gregor, rdieter
Target Milestone: ---Keywords: Patch, Upstream
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: lightdm-1.6.3-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-12 04:25:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix for the leaking sockets none

Description Rumen B. 2013-06-12 09:11:23 UTC
Description of problem:
Each time the greeter starts the number of open FDs increase. After each login and logout cycle the number of open FDs is increased by 6. Which over time leads to impossible logins and the message in /var/log/messages is:

Jun 12 02:44:24 node3 lightdm[17471]: ** (lightdm:17471): WARNING **: Failed to create pipe to communicate with session process: To...en files
Jun 12 02:45:29 node3 lightdm[17471]: ** (lightdm:17471): WARNING **: Failed to create pipes: Too many open files
Jun 12 02:47:47 node3 lightdm[17471]: ** (lightdm:17471): WARNING **: Failed to create pipes: Too many open files


Version-Release number of selected component (if applicable):
Fedora 19 lightdm 1.6.0

How reproducible: always

Steps to Reproduce:

1. login on a console and find the pid of main lightdm process then:
# lsof -p {lightdm_pid} |grep FIFO |wc -l
26

2. switch to X console and login through lightdm and then logout

3. go back on comsole
# lsof -p {lightdm_pid} |grep FIFO |wc -l
32


Actually the number increases when the greeter is started but it never decreases.

Comment 1 Rumen B. 2013-06-12 15:14:56 UTC
Created attachment 760204 [details]
Fix for the leaking sockets

Here is a patch that fixes the issue reported by me earlier today. It may have several lines offset because we use modified lightdm but it is good for the original version too.

regards,
Rumen

Comment 2 Rumen B. 2013-06-12 15:28:13 UTC
Sorry I mean Leaking File descriptors :)

Comment 3 Gregor Tätzner 2013-06-12 15:56:33 UTC
Cool, can you submit that patch upstream?

Comment 4 Rumen B. 2013-06-12 17:32:13 UTC
Probably I can, but i do not know how. Can you shed some light how to do so.

Comment 5 Gregor Tätzner 2013-06-12 19:03:45 UTC
Create or search a bug on launchpad [1] and attach your patch

[1] https://bugs.launchpad.net/lightdm

Comment 6 Fedora Update System 2013-10-06 02:50:49 UTC
lightdm-1.7.17-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/lightdm-1.7.17-2.fc20

Comment 7 Fedora Update System 2013-10-06 05:32:09 UTC
Package lightdm-1.7.17-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing lightdm-1.7.17-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18432/lightdm-1.7.17-2.fc20
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-10-08 21:04:39 UTC
lightdm-1.6.3-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/lightdm-1.6.3-2.fc19

Comment 9 Fedora Update System 2013-10-09 14:23:01 UTC
Package lightdm-1.7.18-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing lightdm-1.7.18-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18432/lightdm-1.7.18-2.fc20
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2013-10-09 20:44:29 UTC
lightdm-1.8.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/lightdm-1.8.0-2.fc20

Comment 11 Fedora Update System 2013-10-12 04:25:51 UTC
lightdm-1.8.0-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2013-10-18 19:35:05 UTC
lightdm-1.6.3-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.