Bug 973629

Summary:	[RHSC] Incorrect events log message seen when a host moves from Non-Operational to UP.
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Shruti Sampat <ssampat>
Component:	rhsc	Assignee:	Shubhendu Tripathi <shtripat>
Status:	CLOSED ERRATA	QA Contact:	Dustin Tsang <dtsang>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	2.1	CC:	dtsang, knarra, mmahoney, mmccune, pprakash, rhs-bugs, sabose, sdharane, ssampat
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	bb5	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-23 22:25:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shruti Sampat 2013-06-12 11:28:56 UTC

Description of problem:
---------------------------------------
When a host, that was in the Non-operational state, comes UP, the message seen in the Events log looks like this - 

Detected new Host <hostname>. Host state was set to Up.

Since it is not a new host that just came UP, the message should convey the correct information, that it was an existing host that was in the Non-Operational state, which just came UP.

Version-Release number of selected component (if applicable):
Red Hat Storage Console Version: 2.1.0-0.bb3.el6rhs 

How reproducible:
Always

Steps to Reproduce:
1. Add a host to a cluster via the Console and let it come UP.
2. Run the following command to stop glusterd on the host - 
   # service glusterd stop
3. After the host goes to the Non-Operational state, run the following command       to start glusterd - 
   # service glusterd start

Actual results:
The above described message is seen in the Events log.

Expected results:
The message should convey the right information as described above.

Additional info:

Comment 1 Shruti Sampat 2013-06-12 11:40:06 UTC

Same is the case when a host goes to UP state after being Non-responsive for a while.

Comment 3 Shubhendu Tripathi 2013-06-18 06:22:04 UTC

Once it comes to refreshing the status of a host it does not have details if the host is newly added or existing one. The status is changed to "Up" after refresh.

The only way to figure out if a host is newly added is the sequence in which the audit log messages are displayed.

In existing scenario, in case of newly added event log messages would be in the below sequence -

"Host <Host Name> was added by admin@internal." followed by 
"Detected new Host <Host Name>. Host state was set to Up."

Whereas in case of host just refreshed from Non-operational to Up would have an event log in the form -

"Detected new Host <Host Name>. Host state was set to Up."

---------------

As correctly identified the message "Detected new Host <Host Name>. Host state was set to Up." is misleading. We will modify the message as below -

"State was set to Up for <Host Name>".

So post changes the event logs in case of newly added host would be as below -

"Host <Host Name> was added by admin@internal." followed by 
"State was set to Up for <Host Name>".

and in case of host just refreshed from Non-operation to Up would be -

"State was set to Up for <Host Name>".

Confirm if the same is fine.

Comment 4 Shruti Sampat 2013-06-18 06:50:34 UTC

Looks good to me.

Comment 5 Dustin Tsang 2013-07-08 19:21:54 UTC

verified in rhsc-bb5

Comment 6 Scott Haines 2013-09-23 22:25:48 UTC

Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. 

For information on the advisory, and where to find the updated files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1262.html