Bug 974469

== Comment: #0 - MANAS K. NAYAK <maknayak.com> - 2013-05-30 11:41:24 ==
Tried do encrypted type installation using F19 Beta ppc64 on P7 system, noticed passphrase confirmation box is insensitive & it blocked encrypt type installation.

Attached two screen shots for reference : encrypt-F19-1.png  encrypt-f19-2.png

--- Steps to reproduce ---
1) boot from virtual dvd of F19 ppc64 Beta
2) do vnc type installation
3) on vnc screen select one disk say sda
4) Then on Installation options screen , 
   - click on "encryot my data, I will set pass phrase later
   - partition scheme should be default LVM
   - click on "Reclaim Space"
   - This will take you the "disk encryption passphrase" screen , where you can see the box for "Confirm" is inactive.
   - And this will remain insensitive , even if I provided paspharse on the 1st box.


== Comment: #9 - Brent J. Baude <baude.com> - 2013-05-31 12:08:08 ==
Manas,

On mine if I hit 'tab' it will take me to the next field, though as you say, you cannot click there.  After hitting tab and getting there, i can use the mouse to switch back and forth.  Same for you?

== Comment: #11 - Kamalesh Babulal <kamaleshb.com> - 2013-06-03 02:55:05 ==
(In reply to comment #9)
> Manas,
> 
> On mine if I hit 'tab' it will take me to the next field, though as you say,
> you cannot click there.  After hitting tab and getting there, i can use the
> mouse to switch back and forth.  Same for you?

There is a bug report files for this https://bugzilla.redhat.com/show_bug.cgi?id=921948

== Comment: #13 - MANAS K. NAYAK <maknayak.com> - 2013-06-04 08:08:27 ==
(In reply to comment #9)
> Manas,
> 
> On mine if I hit 'tab' it will take me to the next field, though as you say,
> you cannot click there.  After hitting tab and getting there, i can use the
> mouse to switch back and forth.  Same for you?

HI Brent,
Yes, your are right. By pressing tab it took me to the next field and henceforth I could use mouse click.
But again if I change passphrase , I need to reuse the tab , no mouse click will work until then.

Thanks...
Manas

== Comment: #17 - Kamalesh Babulal <kamaleshb.com> - 2013-06-07 09:32:55 ==
(In reply to comment #15)
> Need feedback if the RH bz is the same.  Also, lowering from block issue
> because tab works.

I have never hacked anaconda. Its a crude idea, we anyways check for password strength for every key typed into the password text box. Leveraging it the sensitivity of the confirm password can be controlled based on strength:
diff --git a/pyanaconda/ui/gui/spokes/lib/passphrase.py b/pyanaconda/ui/gui/spokes/lib/passphrase.py
index bd41bd5..f533aad 100644
--- a/pyanaconda/ui/gui/spokes/lib/passphrase.py
+++ b/pyanaconda/ui/gui/spokes/lib/passphrase.py
@@ -91,6 +91,7 @@ class PassphraseDialog(GUIObject):
     def _update_passphrase_strength(self):
         passphrase = self._passphrase_entry.get_text()
         strength = 0
+       sensitive = False
         self._pwq_error = ""
         try:
             strength = self._pwq.check(passphrase, None, None)
@@ -100,18 +101,23 @@ class PassphraseDialog(GUIObject):
         if strength < 50:
             val = 1
             text = _("Weak")
+           sensitive = False
         elif strength < 75:
             val = 2
             text = _("Fair")
+           sensitive = True
         elif strength < 90:
             val = 3
             text = _("Good")
+           sensitive = True
         else:
             val = 4
             text = _("Strong")
+           sensitive = True
 
         self._strength_bar.set_value(val)
         self._strength_label.set_text(text)
+       self._confirm_entry.set_sensitive(sensitive)
 
     def _set_entry_icon(self, entry, icon, msg):
         entry.set_icon_from_stock(Gtk.EntryIconPosition.SECONDARY, icon)
@@ -137,7 +143,6 @@ class PassphraseDialog(GUIObject):
             sensitive = False
             self._set_entry_icon(entry, icon, msg)
 
-        self._confirm_entry.set_sensitive(sensitive)
         if sensitive:
             self._confirm_entry.grab_focus()

But one open question remains is should we clear the confirm_password text, whenever we disable the sensitivity of confirm_password.