Bug 975557
| Summary: | Syslog Handler: Message length is not calculated correctly for multi-byte characters | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Kyle Lape <klape> |
| Component: | Logging | Assignee: | James Perkins <jperkins> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.1.0 | CC: | jperkins, lcosti, myarboro, pkremens, rdickens, rsvoboda |
| Target Milestone: | ER4 | ||
| Target Release: | EAP 6.1.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
There existed an issue in previous versions of JBoss EAP 6 where the syslog handler would incorrectly calculate a message length as the number of characters in the message, rather than correctly as the total number of bytes.
If a syslog message contained any characters that were more than one byte in length, for example characters with umlauts, an invalid message length would be sent. As a result of this issue, some log messages contained invalid or missing characters.
In this version of JBoss EAP 6, the syslog handler has been updated and now calculates syslog message lengths correctly. There should no longer be any invalid or missing characters recorded by the syslog handler as a result of invalid message lengths.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-16 20:24:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 975555 | ||
|
Description
Kyle Lape
2013-06-18 18:51:36 UTC
QA NACK: * Upstream commit changes API for format method, no backward compatibility - with default encoding set to UTF-8 * Upstream commit contains new functionality - Add support for TCP and SSL connections on the Syslog handler. Does the fact that this feature is tech preview make a difference on the backward compatibility issue? The bug described here renders the syslog handler useless for anyone that might ever include a multi-byte character in a log message, so it would be great to get this fixed. Perhaps as an alternative, we could at least fix the bug as a separate commit to the internal git repo rather than cherry picking an upstream commit. TP decreases backward compatibility issue argument but still - fixing it isn't such a big problem ... New functionality should go to minor releases so EAP 6.2 should be appropriate target for support of TCP and SSL connections. For 6.1.1 I would like to see commit just for message length fix for multi-byte characters Referenced commit is done in master and not yet back-ported to 1.4 branch - https://github.com/jboss-logging/jboss-logmanager/commits/1.4 I think James could back-port just fix without new features. Any progress on this ? PR without new functionality is fine from QE PoV. Not yet. I need to find a good way to back port it without any added functionality. Not impossible, but I just need to take some time to have a good look at it. https://github.com/jboss-logging/jboss-logmanager/commit/fb105198d6d3d75b703a18dfa251afba0aed9e5b is fix for this issue, granting qa ack Verified on EAP 6.1.1 ER4 |