Bug 975557 - Syslog Handler: Message length is not calculated correctly for multi-byte characters
Summary: Syslog Handler: Message length is not calculated correctly for multi-byte cha...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Logging
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER4
: EAP 6.1.1
Assignee: James Perkins
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 975555
TreeView+ depends on / blocked
 
Reported: 2013-06-18 18:51 UTC by Kyle Lape
Modified: 2018-12-01 15:01 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-09-16 20:24:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Kyle Lape 2013-06-18 18:51:36 UTC
This should be fixed by this commit upstream:

https://github.com/jboss-logging/jboss-logmanager/commit/8599d3c93ab9acec4d42f32524edcb375916eb6b

Comment 1 Rostislav Svoboda 2013-06-20 09:58:39 UTC
QA NACK:
 * Upstream commit changes API for format method, no backward compatibility - with default encoding set to UTF-8
 * Upstream commit contains new functionality - Add support for TCP and SSL connections on the Syslog handler.

Comment 2 Kyle Lape 2013-06-20 15:21:42 UTC
Does the fact that this feature is tech preview make a difference on the backward compatibility issue?  The bug described here renders the syslog handler useless for anyone that might ever include a multi-byte character in a log message, so it would be great to get this fixed.

Perhaps as an alternative, we could at least fix the bug as a separate commit to the internal git repo rather than cherry picking an upstream commit.

Comment 3 Rostislav Svoboda 2013-06-24 09:06:00 UTC
TP decreases backward compatibility issue argument but still - fixing it isn't such a big problem ...

New functionality should go to minor releases so EAP 6.2 should be appropriate target for support of TCP and SSL connections.

For 6.1.1 I would like to see commit just for message length fix for multi-byte characters


Referenced commit is done in master and not yet back-ported to 1.4 branch - https://github.com/jboss-logging/jboss-logmanager/commits/1.4 
I think James could back-port just fix without new features.

Comment 4 Rostislav Svoboda 2013-07-18 13:07:42 UTC
Any progress on this ? PR without new functionality is fine from QE PoV.

Comment 5 James Perkins 2013-07-18 17:07:45 UTC
Not yet. I need to find a good way to back port it without any added functionality. Not impossible, but I just need to take some time to have a good look at it.

Comment 7 Rostislav Svoboda 2013-07-19 10:05:47 UTC
https://github.com/jboss-logging/jboss-logmanager/commit/fb105198d6d3d75b703a18dfa251afba0aed9e5b is fix for this issue, granting qa ack

Comment 9 Petr Kremensky 2013-08-05 10:27:29 UTC
Verified on EAP 6.1.1 ER4


Note You need to log in before you can comment on or make changes to this bug.