Bug 975834

The nature of this RFE has been changed - originally the client should have parsed a menu provided by oVirt REST. This is not true anymore. The new description is:
Client should be able to get the list of available CD images and also perform the change CD using the oVirt REST. oVirt will provide the sessionId to authenticate with the REST and the vmGuid in the .vv file.

This bug would be mine as I've done most of this work upstream. However, since this needs 2 new packages in RHEL6, maybe it's better to only have that in RHEL7 where these packages are already present.

still not in upstream, missing deps, unlikely for 6.6..

Support is upstream and in RHEL7 now.

Tested with:
libgovirt-0.3.2-1.el6.x86_64
virt-viewer-2.0-2.el6.x86_64
rhevm:3.5.0-0.32.el6ev

Steps:
1. Prepare a guset on rhevm, and a ISO domain to rhevm, add more than one cd images in the domain, and add user "admin" to virtual machine permissions

2. on client:
# wget http://rhevm.example.com/ca.crt
# remote-viewer --ovirt-ca-file=ca.crt ovirt://rhevm.example.com/$vm

3. Input right username and password to connect the guest

4.After the guest console is open, check the menu bar of virt-viewer, there are 5 menus:"File", "View", "Send key", "Help", "Change CD".

5.Test "Change CD" menu:
5.1.Click the same image:first click 'rhev-tools-setup.iso' to make the iso mounted in guest,then click the same image to remove it,the iso is still mounted in guest,debug info shows as:

(remote-viewer:12742): remote-viewer-DEBUG: 'rhev-tools-setup.iso' clicked
(remote-viewer:12742): remote-viewer-DEBUG: Updating VM cdrom image to 'rhev-tools-setup.iso'
(remote-viewer:12742): remote-viewer-DEBUG: Finished updating cdrom content
(remote-viewer:12742): remote-viewer-DEBUG: Spice foreign menu updated
(remote-viewer:12742): remote-viewer-DEBUG: Creating GtkMenu for foreign menu
(remote-viewer:12742): remote-viewer-DEBUG: Refreshing foreign menu iso list
(remote-viewer:12742): remote-viewer-DEBUG: 'rhev-tools-setup.iso' clicked
(remote-viewer:12742): remote-viewer-DEBUG: Removing current cdrom image
(remote-viewer:12742): remote-viewer-DEBUG: Finished updating cdrom content
(remote-viewer:12742): remote-viewer-DEBUG: Spice foreign menu updated
(remote-viewer:12742): remote-viewer-DEBUG: Creating GtkMenu for foreign menu

In guest,After second click 'rhev-tools-setup.iso',iso is still mounted.
# mount
/dev/sr0 on /run/media/root/Tools-3.2-17 type iso9660 (ro,nosuid,nodev,relatime,uid=0,gid=0,iocharset=utf8,mode=0400,dmode=0500,uhelper=udisks2)

If I umount the iso manualy then it can not be mounted.
# umount /dev/sr0
# mount /dev/sr0 /mnt
mount: no medium found on /dev/sr0


5.2 Click another image:first click 'rhev-tools-setup.iso' to make the iso mounted in guest,then click another image 'virtio-win.iso'.After a while,'rhev-tools-setup.iso' is still clicked and can be mounted,"Bad Request" warning shows in debug:

(remote-viewer:12985): remote-viewer-DEBUG: 'rhev-tools-setup.iso' clicked
(remote-viewer:12985): remote-viewer-DEBUG: Updating VM cdrom image to 'rhev-tools-setup.iso'
(remote-viewer:12985): remote-viewer-DEBUG: Finished updating cdrom content
(remote-viewer:12985): remote-viewer-DEBUG: Spice foreign menu updated
(remote-viewer:12985): remote-viewer-DEBUG: Creating GtkMenu for foreign menu
(remote-viewer:12985): remote-viewer-DEBUG: Refreshing foreign menu iso list
(remote-viewer:12985): remote-viewer-DEBUG: 'virtio-win.iso' clicked
(remote-viewer:12985): remote-viewer-DEBUG: Updating VM cdrom image to 'virtio-win.iso'
(remote-viewer:12985): remote-viewer-DEBUG: Finished updating cdrom content

(remote-viewer:12985): remote-viewer-WARNING **: failed to update cdrom resource: Bad Request

5.3,After 5.2,if I click 'virtio-win.iso' again,then the iso can be mounted without warning info in debug.

Would you pls help to check the above results in 5.1 and 5.2,is it by design?thanks.

In general, clicking on an already mounted CD should remove it from the VM (ie image unchecked, no more mounted in VM). Clicking on a different CD image should change the currently mounted CD (assuming you are using a desktop environment doing automount). However, with some images, I sometimes need to unmount them manually before being able to use the foreign menu (from GNOME, I right click on the CDRom and pick 'eject'). Maybe that's what you are seeing.
This mounting/unmounting is all handled by RHEV though, the foreign menu code is just asking it to mount/unmount, so if this part is not working as expected, I think this is more a RHEV bug than a virt-viewer/libgovirt one (unless we are not using the RHEV API correctly).

(In reply to Christophe Fergeau from comment #8)
> In general, clicking on an already mounted CD should remove it from the VM
> (ie image unchecked, no more mounted in VM). Clicking on a different CD
> image should change the currently mounted CD (assuming you are using a
> desktop environment doing automount). However, with some images, I sometimes
> need to unmount them manually before being able to use the foreign menu
> (from GNOME, I right click on the CDRom and pick 'eject'). Maybe that's what
> you are seeing.
> This mounting/unmounting is all handled by RHEV though, the foreign menu
> code is just asking it to mount/unmount, so if this part is not working as
> expected, I think this is more a RHEV bug than a virt-viewer/libgovirt one
> (unless we are not using the RHEV API correctly).

Refer to the above comments,the asking mount/unmount action has been executed by virt-viewer GUI,so the bug has been fixed and I will move it to VERIFIED.For the RHEV issue,I will test more and file a new bug if needed.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1322.html