Bug 97784

Summary: initscript has some flaws
Product: [Retired] Red Hat Raw Hide Reporter: Enrico Scholz <rh-bugzilla>
Component: vixie-cronAssignee: Jens Petersen <petersen>
Status: CLOSED CURRENTRELEASE QA Contact: Brock Organ <borgan>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-08-30 23:08:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 170806    

Description Enrico Scholz 2003-06-20 22:09:29 UTC
Description of problem:

There are some flaws in /etc/init.d/crond:

1. reload() should use either 'retval' or 'RETVAL' but not both:
   | reload() {
   |      retval=$?
   |      ...
   |      return $RETVAL
   | }

2. The 'exit $?' at the end of the script is redundant since sh-scripts
   are returning always with the exit-code of the last command ($?)

3. The 'RETVAL=0' statement at the begin of the script does not has an
   effect since RETVAL is used inside of functions only



Version-Release number of selected component (if applicable):

vixie-cron-3.0.1-76

Comment 1 Jens Petersen 2004-06-30 16:31:51 UTC
Thanks, should get finally fixed in vixie-cron-3.0.1-94.

Comment 2 Jason Vas Dias 2004-08-30 23:08:21 UTC
This was fixed vixie-cron-3.0.1-94 & in latest version: vixie-cron-4.1-10.