Bug 97784 - initscript has some flaws
Summary: initscript has some flaws
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Raw Hide
Classification: Retired
Component: vixie-cron
Version: 1.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Brock Organ
URL:
Whiteboard:
Depends On:
Blocks: 170806
TreeView+ depends on / blocked
 
Reported: 2003-06-20 22:09 UTC by Enrico Scholz
Modified: 2007-04-18 16:54 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2004-08-30 23:08:21 UTC
Embargoed:


Attachments (Terms of Use)

Description Enrico Scholz 2003-06-20 22:09:29 UTC
Description of problem:

There are some flaws in /etc/init.d/crond:

1. reload() should use either 'retval' or 'RETVAL' but not both:
   | reload() {
   |      retval=$?
   |      ...
   |      return $RETVAL
   | }

2. The 'exit $?' at the end of the script is redundant since sh-scripts
   are returning always with the exit-code of the last command ($?)

3. The 'RETVAL=0' statement at the begin of the script does not has an
   effect since RETVAL is used inside of functions only



Version-Release number of selected component (if applicable):

vixie-cron-3.0.1-76

Comment 1 Jens Petersen 2004-06-30 16:31:51 UTC
Thanks, should get finally fixed in vixie-cron-3.0.1-94.

Comment 2 Jason Vas Dias 2004-08-30 23:08:21 UTC
This was fixed vixie-cron-3.0.1-94 & in latest version: vixie-cron-4.1-10.


Note You need to log in before you can comment on or make changes to this bug.