Bug 978975

Summary:	[RFE] Set images status to be Illegal when they could not be marked as ready to delete in the storage domain
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Maor <mlipchuk>
Component:	ovirt-engine	Assignee:	Maor <mlipchuk>
Status:	CLOSED WONTFIX	QA Contact:	Raz Tamir <ratamir>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	jbainbri, kgoldbla, lpeer, mlipchuk, rbalakri, Rhev-m-bugs, scohen, sgotliv, srevivo, ylavi
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---	Flags:	sherold: Triaged+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-04 08:28:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	960169
Bug Blocks:

Description Maor 2013-06-27 12:17:09 UTC

Description of problem:
Images which are not able to be marked as deleted in the storage by VDSM should be marked as Illegal in the engine DB, so user will be able to delete them again.

un-succeeded deletion can be on move operation (When the original copy is deleted at the end of the process)
also at create VM from template or create template which fails.
import VM which fails and so on.

The purpose of this RFE is to solve an issue when images will be blocked from being removed since other shared volumes still hasn't been removed from the storage (for example a template which has based VM images related to it).
To prevent a scenario, which those images are no longer in the DB, we should leave those images in the DB until they are marked as removed in the storage.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
Images which are not able to be marked as removed from the storage by VDSM should be marked as Illegal in the engine DB, so user will be able to delete them again.

Additional info:

Comment 1 Maor 2013-06-27 12:27:32 UTC

*** Bug 965936 has been marked as a duplicate of this bug. ***

Comment 2 Maor 2013-07-09 07:28:33 UTC

Link to the wiki : http://www.ovirt.org/Features/Move_Disk_Two_Phase_Commit

Comment 3 Ayal Baron 2013-09-19 15:53:48 UTC

Sergey, this sounds like something you're already working on?

Comment 4 Sergey Gotliv 2013-12-03 13:22:59 UTC

I'll take it with Maor, I think its already resolved in 3.3.

Comment 6 Allon Mureinik 2014-05-07 08:30:57 UTC

(In reply to Sergey Gotliv from comment #4)
> I'll take it with Maor, I think its already resolved in 3.3.

So was it?

Comment 7 Maor 2014-06-18 08:54:50 UTC

Currently we mark those disks with ILLEGAL only on delete, but we still don't support the move operation (which deletes the image from the source domain).
The fix for that should also be taken care of with this bug https://bugzilla.redhat.com/960169

Comment 9 Allon Mureinik 2017-01-31 12:36:22 UTC

Liron - is this even relevant nowadays?

Comment 10 Liron Aravot 2017-02-02 16:28:09 UTC

Allon, yes.
Once BZ 960169 will be solved, we'll be able to leave the db record for the disk on the source domain in ILLEGAL status which will let the user to attempt to delete it.
As today we support only one copy for a regular disk - there's an audit log indicating that there are leftovers on the storage but you can't clean it using the engine.

BZ 1416113 is also a duplicate of this bug.

Comment 11 Liron Aravot 2017-02-02 16:28:49 UTC

*** Bug 1416113 has been marked as a duplicate of this bug. ***

Comment 12 Yaniv Lavi 2018-06-04 08:28:34 UTC

Closing old RFEs, please reopen if still relevant.

Comment 13 Franta Kust 2019-05-16 13:04:59 UTC

BZ<2>Jira Resync