Bug 978975 - [RFE] Set images status to be Illegal when they could not be marked as ready to delete in the storage domain
Summary: [RFE] Set images status to be Illegal when they could not be marked as ready ...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Maor
QA Contact: Raz Tamir
URL:
Whiteboard:
: 965936 1416113 (view as bug list)
Depends On: 960169
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-27 12:17 UTC by Maor
Modified: 2019-05-16 13:04 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-04 08:28:34 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:
sherold: Triaged+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 379083 0 None None None 2018-12-01 14:49:55 UTC

Description Maor 2013-06-27 12:17:09 UTC
Description of problem:
Images which are not able to be marked as deleted in the storage by VDSM should be marked as Illegal in the engine DB, so user will be able to delete them again.

un-succeeded deletion can be on move operation (When the original copy is deleted at the end of the process)
also at create VM from template or create template which fails.
import VM which fails and so on.

The purpose of this RFE is to solve an issue when images will be blocked from being removed since other shared volumes still hasn't been removed from the storage (for example a template which has based VM images related to it).
To prevent a scenario, which those images are no longer in the DB, we should leave those images in the DB until they are marked as removed in the storage.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
Images which are not able to be marked as removed from the storage by VDSM should be marked as Illegal in the engine DB, so user will be able to delete them again.

Additional info:

Comment 1 Maor 2013-06-27 12:27:32 UTC
*** Bug 965936 has been marked as a duplicate of this bug. ***

Comment 2 Maor 2013-07-09 07:28:33 UTC
Link to the wiki : http://www.ovirt.org/Features/Move_Disk_Two_Phase_Commit

Comment 3 Ayal Baron 2013-09-19 15:53:48 UTC
Sergey, this sounds like something you're already working on?

Comment 4 Sergey Gotliv 2013-12-03 13:22:59 UTC
I'll take it with Maor, I think its already resolved in 3.3.

Comment 6 Allon Mureinik 2014-05-07 08:30:57 UTC
(In reply to Sergey Gotliv from comment #4)
> I'll take it with Maor, I think its already resolved in 3.3.

So was it?

Comment 7 Maor 2014-06-18 08:54:50 UTC
Currently we mark those disks with ILLEGAL only on delete, but we still don't support the move operation (which deletes the image from the source domain).
The fix for that should also be taken care of with this bug https://bugzilla.redhat.com/960169

Comment 9 Allon Mureinik 2017-01-31 12:36:22 UTC
Liron - is this even relevant nowadays?

Comment 10 Liron Aravot 2017-02-02 16:28:09 UTC
Allon, yes.
Once BZ 960169 will be solved, we'll be able to leave the db record for the disk on the source domain in ILLEGAL status which will let the user to attempt to delete it.
As today we support only one copy for a regular disk - there's an audit log indicating that there are leftovers on the storage but you can't clean it using the engine.

BZ 1416113 is also a duplicate of this bug.

Comment 11 Liron Aravot 2017-02-02 16:28:49 UTC
*** Bug 1416113 has been marked as a duplicate of this bug. ***

Comment 12 Yaniv Lavi 2018-06-04 08:28:34 UTC
Closing old RFEs, please reopen if still relevant.

Comment 13 Franta Kust 2019-05-16 13:04:59 UTC
BZ<2>Jira Resync


Note You need to log in before you can comment on or make changes to this bug.