Bug 979656
Summary: | Review Request: perl-Set-Array - Arrays as objects with lots of handy methods | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, panemade |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Set-Array-0.29-2.fc18 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-07-22 00:37:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 987717 |
Description
Christopher Meng
2013-06-29 06:42:09 UTC
This package is not acceptable in Fedora as upstream clearly mentioned its released under Artistic 1.0 license. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses See if upstream can release it under same license as Perl itself and then re-open this with new tarball. I'll ask if the author can change, then handle the bug. Upstream said that the worng license is a typo, so this package can be packaged now. NEW SPEC URL: http://cicku.me/perl-Set-Array.spec NEW SRPM URL: http://cicku.me/perl-Set-Array-0.29-1.fc20.src.rpm Review: + mock build is successful for f20 - rpmlint output on rpms gave perl-Set-Array.noarch: W: spelling-error %description -l en_US lang -> Lang, lag, slang perl-Set-Array.noarch: W: file-not-utf8 /usr/share/doc/perl-Set-Array-0.29/Changelog.ini perl-Set-Array.noarch: W: file-not-utf8 /usr/share/doc/perl-Set-Array-0.29/Changes perl-Set-Array.src: W: spelling-error %description -l en_US lang -> Lang, lag, slang 2 packages and 0 specfiles checked; 0 errors, 4 warnings. ==> Fix the rpmlint warnings + Source verified with upstream as (sha256sum) srpm tarball : 4e1e35ae5480310032754f5410eaba9381c6c84c992d6f6ec59aad2b84c38c3d upstream tarball : 4e1e35ae5480310032754f5410eaba9381c6c84c992d6f6ec59aad2b84c38c3d + License "Artistic 2.0" is valid. + rest follows packaging guidelines + make test is successful with output All tests successful. + Package: perl-Set-Array-0.29-1.fc20.noarch Provides: perl(Set::Array) = 0.29 perl-Set-Array = 0.29-1.fc20 Requires: perl(Carp) perl(Try::Tiny) perl(Want) perl(attributes) perl(strict) perl(subs) suggestions: 1) Remove Changelog.ini as it looks same as Changes file. 2) Fix rpmlint file-not-utf8 by adding following to %prep iconv -f iso8859-1 -t utf-8 Changes > Changes.conv && mv -f Changes.conv Changes 3) Remove commented lines if you are not planning to use them. Hi, The author just changed the license, as a result my waiting is over, I will update soon. License changed again from Artistic 2.0 ?? Ah.... Wrong paste to the bug... NEW SPEC URL: http://cicku.me/perl-Set-Array.spec NEW SRPM URL: http://cicku.me/perl-Set-Array-0.29-2.fc20.src.rpm Besides I have no commented lines in spec. Looks good. APPROVED. New Package SCM Request ======================= Package Name: perl-Set-Array Short Description: Arrays as objects with lots of handy methods Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). perl-Set-Array-0.29-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Set-Array-0.29-2.fc19 perl-Set-Array-0.29-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Set-Array-0.29-2.fc18 perl-Set-Array-0.29-2.fc19 has been pushed to the Fedora 19 testing repository. perl-Set-Array-0.29-2.fc19 has been pushed to the Fedora 19 stable repository. perl-Set-Array-0.29-2.fc18 has been pushed to the Fedora 18 stable repository. |