Bug 979673
Summary: | Review Request: perl-File-Find-Object - Object oriented File::Find replacement | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-File-Find-Object-0.2.7-2.fc18 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-07-15 01:01:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 698301, 979670 | ||
Bug Blocks: | 979674 |
Description
Christopher Meng
2013-06-29 10:14:53 UTC
Review: + mock build is successful for f20 - rpmlint on rpms gave perl-File-Find-Object.noarch: W: doc-file-dependency /usr/share/doc/perl-File-Find-Object-0.2.7/examples/tree perl(Getopt::Long) perl-File-Find-Object.noarch: W: doc-file-dependency /usr/share/doc/perl-File-Find-Object-0.2.7/examples/tree /usr/bin/perl 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 403e8b7062fff32785ac722f3fe56b32c3641ee219d719f2e762ff441215aed7 upstream tarball : 403e8b7062fff32785ac722f3fe56b32c3641ee219d719f2e762ff441215aed7 - License "GPL+ or Artistic" is not exactly valid. - make test is successful with output looks all test successful but some got skipped + This package Provides: perl(File::Find::Object) = 0.2.7 perl(File::Find::Object::Base) perl(File::Find::Object::DeepPath) perl(File::Find::Object::PathComp) perl(File::Find::Object::Result) perl(File::Find::Object::TopPath) perl-File-Find-Object = 0.2.7-1.fc20 Requires: /usr/bin/perl perl(Carp) perl(Fcntl) perl(File::Find::Object) perl(File::Find::Object::Base) perl(File::Find::Object::PathComp) perl(File::Find::Object::Result) perl(File::Spec) perl(Getopt::Long) perl(List::Util) perl(base) perl(integer) perl(strict) perl(warnings) suggestions: 1) rpm can automatically find required packages for perl packages so don't need to explicitly mention following in spec file. Please remove it. Requires: perl(Carp) Requires: perl(Class::XSAccessor) Requires: perl(File::Spec) Requires: perl(List::Util) 2) From README and source files, its clear that license tag should be "GPLv2+ or Artistic" 3) Add following for executing all the tests BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod) #BuildRequires: perl(Test::TrailingSpace) I see perl-Test-TrailingSpace is not available in Fedora. Though its not mandatory but good if you can package it also. http://search.cpan.org/dist/Test-TrailingSpace/ 4) rpmlint warning doc-file-dependency can be fixed by adding following in %prep chmod 644 examples/tree Test::TrailingSpace is packaged when I submitted this one, see https://bugzilla.redhat.com/show_bug.cgi?id=979676 NEW SPEC URL: http://cicku.me/perl-File-Find-Object.spec NEW SRPM URL: http://cicku.me/perl-File-Find-Object-0.2.7-2.fc20.src.rpm Thanks for the update. Now, I see rpm does not automatically extracted following Requires: perl(Class::XSAccessor) Please add this back in spec. APPROVED. Will review 979676 package later on. New Package SCM Request ======================= Package Name: perl-File-Find-Object Short Description: Object oriented File::Find replacement Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). perl-File-Find-Object-0.2.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-File-Find-Object-0.2.7-2.fc18 perl-File-Find-Object-0.2.7-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-File-Find-Object-0.2.7-2.fc19 perl-File-Find-Object-0.2.7-2.fc19 has been pushed to the Fedora 19 testing repository. perl-File-Find-Object-0.2.7-2.fc19 has been pushed to the Fedora 19 stable repository. perl-File-Find-Object-0.2.7-2.fc18 has been pushed to the Fedora 18 stable repository. Package Change Request ====================== Package Name: perl-File-Find-Object New Branches: epel7 Owners: cicku Git done (by process-git-requests). |