Bug 979673 - Review Request: perl-File-Find-Object - Object oriented File::Find replacement
Summary: Review Request: perl-File-Find-Object - Object oriented File::Find replacement
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
Depends On: 698301 979670
Blocks: 979674
TreeView+ depends on / blocked
Reported: 2013-06-29 10:14 UTC by Christopher Meng
Modified: 2014-06-19 20:52 UTC (History)
3 users (show)

Fixed In Version: perl-File-Find-Object-0.2.7-2.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-07-15 01:01:52 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Meng 2013-06-29 10:14:53 UTC
Spec URL: http://cicku.me/perl-File-Find-Object.spec
SRPM URL: http://cicku.me/perl-File-Find-Object-0.2.7-1.fc20.src.rpm
Description: File::Find::Object does the same job as File::Find but works like an object and with an iterator. As File::Find is not object oriented, one cannot
perform multiple searches in the same application. The second problem of
File::Find is its file processing: after starting its main loop, one cannot
easily wait for another event and so get the next result.
Fedora Account System Username: cicku

Comment 1 Parag AN(पराग) 2013-07-03 04:45:05 UTC

+ mock build is successful for f20

- rpmlint on rpms gave
perl-File-Find-Object.noarch: W: doc-file-dependency /usr/share/doc/perl-File-Find-Object-0.2.7/examples/tree perl(Getopt::Long)
perl-File-Find-Object.noarch: W: doc-file-dependency /usr/share/doc/perl-File-Find-Object-0.2.7/examples/tree /usr/bin/perl
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 403e8b7062fff32785ac722f3fe56b32c3641ee219d719f2e762ff441215aed7
upstream tarball : 403e8b7062fff32785ac722f3fe56b32c3641ee219d719f2e762ff441215aed7

- License "GPL+ or Artistic" is not exactly valid.

- make test is successful with output
looks all test successful but some got skipped

+ This package
Provides: perl(File::Find::Object) = 0.2.7 perl(File::Find::Object::Base) perl(File::Find::Object::DeepPath) perl(File::Find::Object::PathComp) perl(File::Find::Object::Result) perl(File::Find::Object::TopPath) perl-File-Find-Object = 0.2.7-1.fc20

Requires: /usr/bin/perl perl(Carp) perl(Fcntl) perl(File::Find::Object) perl(File::Find::Object::Base) perl(File::Find::Object::PathComp) perl(File::Find::Object::Result) perl(File::Spec) perl(Getopt::Long) perl(List::Util) perl(base) perl(integer) perl(strict) perl(warnings)

1) rpm can automatically find required packages for perl packages so don't need to explicitly mention following in spec file. Please remove it.
Requires:       perl(Carp)
Requires:       perl(Class::XSAccessor)
Requires:       perl(File::Spec)
Requires:       perl(List::Util)

2) From README and source files, its clear that license tag should be "GPLv2+ or Artistic"  

3) Add following for executing all the tests
BuildRequires:  perl(Test::Pod::Coverage)
BuildRequires:  perl(Test::Pod)
#BuildRequires:  perl(Test::TrailingSpace)

I see perl-Test-TrailingSpace is not available in Fedora. Though its not mandatory but good if you can package it also.

4) rpmlint warning doc-file-dependency can be fixed by adding following in %prep
 chmod 644 examples/tree

Comment 2 Christopher Meng 2013-07-03 06:14:54 UTC
Test::TrailingSpace is packaged when I submitted this one, see https://bugzilla.redhat.com/show_bug.cgi?id=979676

NEW SPEC URL: http://cicku.me/perl-File-Find-Object.spec
NEW SRPM URL: http://cicku.me/perl-File-Find-Object-0.2.7-2.fc20.src.rpm

Comment 3 Parag AN(पराग) 2013-07-03 06:54:54 UTC
Thanks for the update. Now, I see rpm does not automatically extracted following
Requires:       perl(Class::XSAccessor)

Please add this back in spec.


Will review 979676 package later on.

Comment 4 Christopher Meng 2013-07-03 09:45:44 UTC
New Package SCM Request
Package Name: perl-File-Find-Object
Short Description: Object oriented File::Find replacement
Owners: cicku
Branches: f18 f19

Comment 5 Gwyn Ciesla 2013-07-03 13:16:57 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-07-05 11:46:20 UTC
perl-File-Find-Object-0.2.7-2.fc18 has been submitted as an update for Fedora 18.

Comment 7 Fedora Update System 2013-07-05 11:47:09 UTC
perl-File-Find-Object-0.2.7-2.fc19 has been submitted as an update for Fedora 19.

Comment 8 Fedora Update System 2013-07-06 00:56:00 UTC
perl-File-Find-Object-0.2.7-2.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-07-15 01:01:52 UTC
perl-File-Find-Object-0.2.7-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 10 Fedora Update System 2013-07-15 01:09:19 UTC
perl-File-Find-Object-0.2.7-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 11 Christopher Meng 2014-06-18 17:02:52 UTC
Package Change Request
Package Name: perl-File-Find-Object
New Branches: epel7
Owners: cicku

Comment 12 Kevin Fenzi 2014-06-19 20:52:23 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.