Bug 979793 (php-symfony2-Debug)

Summary: Review Request: php-symfony2-Debug - Symfony2 Debug Component
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-22 19:48:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2013-06-30 16:49:18 UTC 
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Debug.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Debug-2.3.1-1.fc18.src.rpm

Description:
The Debug Component provides tools to ease debugging PHP code.

Fedora Account System Username: siwinski
Comment 1 Remi Collet 2013-10-20 06:01:56 UTC 
Created attachment 814160 [details]
phpci.log

phpcompatinfo version 2.24.0.
Comment 2 Remi Collet 2013-10-20 06:02:43 UTC 
Created attachment 814161 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 979793
Buildroot used: fedora-19-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG
Comment 3 Remi Collet 2013-10-20 06:03:25 UTC 
Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=6080475

Issues:
=======
[!]: Sources used to build the package match the upstream source, as provided in
  the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/extras/SPECS/review/979793-php-symfony2-Debug/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL
	=> minor diff in the package.xml which have 
	obviously be regenerated, not an issue for the review
[~]: Package is named according to the Package Naming Guidelines.
	New Guildelines recommend the use of lowercase names.
	As all the symfony2 stack use CamelCase, I thinks
	this could be ignored.
[!]: Package consistently uses macros (instead of hard-coded directory names).
	=> only a small comment
	symfony_{min,max}_ver could be ambiguous, as according to various
	composer.json, you have not a single minimal version, some
	could require 2.0, 2.1, 2.2 or 2.3. So a per component version
	seems clearer.
[~]: Package is named according to the Package Naming Guidelines.
	New Guildelines recommend the use of lowercase names.
	As all the symfony2 stack use CamelCase, I thinks
	this could be ignored.
[!]: Requires correct, justified where necessary.
	php-common => php(language)
[!]: Latest version is packaged.
	2.3.6 available
Comment 4 Shawn Iwinski 2013-10-22 01:47:27 UTC 
I just submitted the single-spec php-symfony2 review request (bug 1021749) that I would prefer to move to.
Comment 5 Shawn Iwinski 2013-11-22 19:48:22 UTC 

*** This bug has been marked as a duplicate of bug 1021749 ***