Bug 980153

Summary:	[RFE] rlFileBackup --clean by default
Product:	[Fedora] Fedora	Reporter:	Dalibor Pospíšil <dapospis>
Component:	beakerlib	Assignee:	Petr Muller <pmuller>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dapospis, dspurek, ohudlick, pmuller, psplicha
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-02 15:44:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dalibor Pospíšil 2013-07-01 14:40:24 UTC

What about setting --clean as default behavior? I would guess that this will not cause problems.

If the problem is that rm -rf is called before it could be done in more intelligent way like remove only new files and restore the rest, see bug 961623.

Comment 1 Petr Muller 2013-07-15 16:18:34 UTC

Why do this? What will get better? I need some arguments for the change.

--clean is not safe to call universally, and I do not want to make it "safer" because it is complicated enough already. That's my argument for not doing it.

Comment 2 Dalibor Pospíšil 2013-07-16 12:44:44 UTC

I think that it is just obvious.

When I did not know about --clean option I assumed that it is the default so a lot of my tests does not use it which is sometimes wrong.

But I must agree that from backward compatibility point of view it is not very safe.

Comment 3 Petr Muller 2013-12-02 15:44:12 UTC

Not backward compatible, I'm not convinced to do it.