Bug 980168

Update:

Spec URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2.spec
SRPM URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2-0.0.4-3.fc18.src.rpm

Patch adding LICENSE file to distribution tarball accepted upstream.

Hello Richard,

The spec file is good! But, required the license file.

Please add the license through upstream.

You can use the TornadIO2's github repository. [0] There is the license file [1]. Will be added as Source1.

[0] https://github.com/mrjoes/tornadio2
[1] https://raw.github.com/mrjoes/tornadio2/master/LICENSE

Hi Richard see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#License_of_Fedora_SPEC_Files not there reason for the license be ASL 2.0 in this spec file; at least that this spec be exactly equal that of Suse

Hi,

update with added LICENSE file:

Spec URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2.spec
SRPM URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2-0.0.4-4.fc19.src.rpm

(In reply to Eduardo Echeverria from comment #3)
> Hi Richard see
> https://fedoraproject.org/wiki/Licensing:
> Main?rd=Licensing#License_of_Fedora_SPEC_Files not there reason for the
> license be ASL 2.0 in this spec file; at least that this spec be exactly
> equal that of Suse

I'm not sure which license you are refering to. License: ASL 2.0 field seems to be correct and the header is from original spec file which seems fine considering the link you've posted.

(In reply to Richard Marko from comment #5)
> (In reply to Eduardo Echeverria from comment #3)
> > Hi Richard see
> > https://fedoraproject.org/wiki/Licensing:
> > Main?rd=Licensing#License_of_Fedora_SPEC_Files not there reason for the
> > license be ASL 2.0 in this spec file; at least that this spec be exactly
> > equal that of Suse
> 
> I'm not sure which license you are refering to. License: ASL 2.0 field seems
> to be correct and the header is from original spec file which seems fine
> considering the link you've posted.

I Quote the header license of your spec

"All modifications and additions to the file contributed by third parties
remain the property of their copyright owners, unless otherwise agreed
upon. The license for this file, and modifications and additions to the
file, is the same license as for the pristine package itself"

Note: "is the same license as for the pristine package itself..."

Now, I wondering, is this spec, the same spec of suse?

if so, mantain the license

if not, I quote our guidelines: 
"All original Fedora contributions are governed by the Fedora Project Contributor Agreement (FPCA). This means that unless a spec file contains an explicit license attribution within it, it is available under the terms of the MIT license."

So, Just is a question about the spec license.

Best Regards

(In reply to Eduardo Echeverria from comment #6)
> 
> Now, I wondering, is this spec, the same spec of suse?
>
> if so, mantain the license
> 

Yes, the spec file comes from suse and it retains original copyright notice so it should be correct.

Why can't you write one?

This package's spec is really easy, but you still waste many lines.

I don't understand why we ship works from SUSE.

SPEC file shouldn't contain any license as such files are not code.

(In reply to Christopher Meng from comment #8)
> Why can't you write one?
> 
> This package's spec is really easy, but you still waste many lines.
> 
> I don't understand why we ship works from SUSE.
> 

Because I have better things to do than rewriting good spec files just to save few lines of copyright notice and because it makes much more sense than to write and maintain another spec file.

> SPEC file shouldn't contain any license as such files are not code.

No. According to guidelines this is perfectly fine.

Hello Richard!

The spec and srpm is fine!

----------------------------

PACKAGE APPROVED

----------------------------

Thank you for the review! and sorry for the delay :)

New Package SCM Request
=======================
Package Name: python-TornadIO2
Short Description: Socket.io server on top of Tornado framework
Owners: rmarko
Branches: f19 f20 el6
InitialCC:

equested package name python-TornadIO2 doesn't match bug summary
python-tornadIO2, please correct.

Renaming according to spec file.

Git done (by process-git-requests).

python-TornadIO2-0.0.4-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-TornadIO2-0.0.4-4.fc19

python-TornadIO2-0.0.4-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-TornadIO2-0.0.4-4.fc20

python-TornadIO2-0.0.4-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-TornadIO2-0.0.4-4.el6

python-TornadIO2-0.0.4-4.el6 has been pushed to the Fedora EPEL 6 testing repository.

python-TornadIO2-0.0.4-4.el6 has been pushed to the Fedora EPEL 6 stable repository.

python-TornadIO2-0.0.4-4.fc19 has been pushed to the Fedora 19 stable repository.

python-TornadIO2-0.0.4-4.fc20 has been pushed to the Fedora 20 stable repository.