Bug 980168 - Review Request: python-TornadIO2 - Socket.io server on top of Tornado framework
Summary: Review Request: python-TornadIO2 - Socket.io server on top of Tornado framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Yohan Graterol
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-01 15:08 UTC by Richard Marko
Modified: 2016-02-01 02:22 UTC (History)
6 users (show)

Fixed In Version: python-TornadIO2-0.0.4-4.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-03 21:57:48 UTC
Type: ---
Embargoed:
yohangraterol92: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Richard Marko 2013-07-01 15:08:18 UTC
Spec URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2.spec
SRPM URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2-0.0.4-2.fc18.src.rpm
Description: Socket.io server on top of Tornado framework
Fedora Account System Username: rmarko

Comment 1 Richard Marko 2013-07-10 12:59:03 UTC
Update:

Spec URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2.spec
SRPM URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2-0.0.4-3.fc18.src.rpm

Patch adding LICENSE file to distribution tarball accepted upstream.

Comment 2 Yohan Graterol 2013-08-12 01:52:52 UTC
Hello Richard,

The spec file is good! But, required the license file.

Please add the license through upstream.

You can use the TornadIO2's github repository. [0] There is the license file [1]. Will be added as Source1.

[0] https://github.com/mrjoes/tornadio2
[1] https://raw.github.com/mrjoes/tornadio2/master/LICENSE

Comment 3 Eduardo Echeverria 2013-08-12 02:33:36 UTC
Hi Richard see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#License_of_Fedora_SPEC_Files not there reason for the license be ASL 2.0 in this spec file; at least that this spec be exactly equal that of Suse

Comment 4 Richard Marko 2013-08-12 14:29:36 UTC
Hi,

update with added LICENSE file:

Spec URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2.spec
SRPM URL: http://rmarko.fedorapeople.org/packages/python-TornadIO2-0.0.4-4.fc19.src.rpm

Comment 5 Richard Marko 2013-08-12 14:36:52 UTC
(In reply to Eduardo Echeverria from comment #3)
> Hi Richard see
> https://fedoraproject.org/wiki/Licensing:
> Main?rd=Licensing#License_of_Fedora_SPEC_Files not there reason for the
> license be ASL 2.0 in this spec file; at least that this spec be exactly
> equal that of Suse

I'm not sure which license you are refering to. License: ASL 2.0 field seems to be correct and the header is from original spec file which seems fine considering the link you've posted.

Comment 6 Eduardo Echeverria 2013-08-13 04:59:11 UTC

(In reply to Richard Marko from comment #5)
> (In reply to Eduardo Echeverria from comment #3)
> > Hi Richard see
> > https://fedoraproject.org/wiki/Licensing:
> > Main?rd=Licensing#License_of_Fedora_SPEC_Files not there reason for the
> > license be ASL 2.0 in this spec file; at least that this spec be exactly
> > equal that of Suse
> 
> I'm not sure which license you are refering to. License: ASL 2.0 field seems
> to be correct and the header is from original spec file which seems fine
> considering the link you've posted.

I Quote the header license of your spec

"All modifications and additions to the file contributed by third parties
remain the property of their copyright owners, unless otherwise agreed
upon. The license for this file, and modifications and additions to the
file, is the same license as for the pristine package itself"

Note: "is the same license as for the pristine package itself..."

Now, I wondering, is this spec, the same spec of suse?

if so, mantain the license

if not, I quote our guidelines: 
"All original Fedora contributions are governed by the Fedora Project Contributor Agreement (FPCA). This means that unless a spec file contains an explicit license attribution within it, it is available under the terms of the MIT license."

So, Just is a question about the spec license.

Best Regards

Comment 7 Richard Marko 2013-08-26 10:56:12 UTC
(In reply to Eduardo Echeverria from comment #6)
> 
> Now, I wondering, is this spec, the same spec of suse?
>
> if so, mantain the license
> 

Yes, the spec file comes from suse and it retains original copyright notice so it should be correct.

Comment 8 Christopher Meng 2013-08-26 11:04:16 UTC
Why can't you write one?

This package's spec is really easy, but you still waste many lines.

I don't understand why we ship works from SUSE.

SPEC file shouldn't contain any license as such files are not code.

Comment 9 Richard Marko 2013-08-26 11:23:39 UTC
(In reply to Christopher Meng from comment #8)
> Why can't you write one?
> 
> This package's spec is really easy, but you still waste many lines.
> 
> I don't understand why we ship works from SUSE.
> 

Because I have better things to do than rewriting good spec files just to save few lines of copyright notice and because it makes much more sense than to write and maintain another spec file.

> SPEC file shouldn't contain any license as such files are not code.

No. According to guidelines this is perfectly fine.

Comment 10 Yohan Graterol 2013-09-07 05:14:43 UTC
Hello Richard!

The spec and srpm is fine!

----------------------------

PACKAGE APPROVED

----------------------------

Comment 11 Richard Marko 2013-10-09 08:23:49 UTC
Thank you for the review! and sorry for the delay :)

Comment 12 Richard Marko 2013-10-09 08:24:13 UTC
New Package SCM Request
=======================
Package Name: python-TornadIO2
Short Description: Socket.io server on top of Tornado framework
Owners: rmarko
Branches: f19 f20 el6
InitialCC:

Comment 13 Gwyn Ciesla 2013-10-09 12:06:06 UTC
equested package name python-TornadIO2 doesn't match bug summary
python-tornadIO2, please correct.

Comment 14 Richard Marko 2013-10-09 12:42:14 UTC
Renaming according to spec file.

Comment 15 Gwyn Ciesla 2013-10-09 13:08:15 UTC
Git done (by process-git-requests).

Comment 16 Fedora Update System 2013-10-17 08:31:34 UTC
python-TornadIO2-0.0.4-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-TornadIO2-0.0.4-4.fc19

Comment 17 Fedora Update System 2013-10-17 08:32:31 UTC
python-TornadIO2-0.0.4-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-TornadIO2-0.0.4-4.fc20

Comment 18 Fedora Update System 2013-10-17 08:33:21 UTC
python-TornadIO2-0.0.4-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-TornadIO2-0.0.4-4.el6

Comment 19 Fedora Update System 2013-10-17 18:08:13 UTC
python-TornadIO2-0.0.4-4.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 20 Fedora Update System 2013-12-03 21:57:48 UTC
python-TornadIO2-0.0.4-4.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 21 Fedora Update System 2013-12-04 07:01:34 UTC
python-TornadIO2-0.0.4-4.fc19 has been pushed to the Fedora 19 stable repository.

Comment 22 Fedora Update System 2013-12-14 03:46:47 UTC
python-TornadIO2-0.0.4-4.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.