Bug 981200

Summary: Review Request: perl-MooseX-Types-DateTime-MoreCoercions - Extensions to MooseX::Types::DateTime
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Christopher Meng <i>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: i, notting, package-review
Target Milestone: ---Flags: i: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-MooseX-Types-DateTime-MoreCoercions-0.11-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-26 12:19:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 890721    

Description Petr Pisar 2013-07-04 09:07:41 UTC 
Spec URL: http://ppisar.fedorapeople.org/perl-MooseX-Types-DateTime-MoreCoercions/perl-MooseX-Types-DateTime-MoreCoercions.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-MooseX-Types-DateTime-MoreCoercions/perl-MooseX-Types-DateTime-MoreCoercions-0.11-1.fc20.src.rpm
Description:
This module builds on MooseX::Types::DateTime to add additional custom
types and coercions. Since it builds on an existing type, all coercions
and constraints are inherited.

Fedora Account System Username: ppisar
Comment 1 Christopher Meng 2013-07-04 09:22:26 UTC 
Do we need versioned BRs?
Comment 2 Petr Pisar 2013-07-04 12:03:34 UTC 
The code does not accept any version. Without suitable version the code fails at compilation time. The build-requires just reflect constrains of package code. So it's not wrong to specify the versions.

The question if its needed is different problem. Fedora guidelines allows to omit versions if the all supported Fedora distributions provides fulfilling versions. I did not checked if the this is the case.

However keeping versions allows to port the package for different distributions (e.g. an EPEL) easily.

Also keeping versions allows automated source upgrade when the automated process starts with rigid and correct spec file, so consequent delta tests will produce minimal differences that are easy to review.
Comment 3 Christopher Meng 2013-07-26 03:45:10 UTC 
Reviewed.

APPROVED.
Comment 4 Petr Pisar 2013-07-26 05:59:35 UTC 
New Package SCM Request
=======================
Package Name: perl-MooseX-Types-DateTime-MoreCoercions
Short Description: Extensions to MooseX::Types::DateTime
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2013-07-26 11:54:25 UTC 
Git done (by process-git-requests).
Comment 6 Petr Pisar 2013-07-26 12:19:28 UTC 
Thank you for the review and the repository.