Bug 981200 - Review Request: perl-MooseX-Types-DateTime-MoreCoercions - Extensions to MooseX::Types::DateTime
Summary: Review Request: perl-MooseX-Types-DateTime-MoreCoercions - Extensions to Moos...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 890721
TreeView+ depends on / blocked
 
Reported: 2013-07-04 09:07 UTC by Petr Pisar
Modified: 2013-07-26 12:19 UTC (History)
3 users (show)

Fixed In Version: perl-MooseX-Types-DateTime-MoreCoercions-0.11-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-26 12:19:28 UTC
Type: ---
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2013-07-04 09:07:41 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-MooseX-Types-DateTime-MoreCoercions/perl-MooseX-Types-DateTime-MoreCoercions.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-MooseX-Types-DateTime-MoreCoercions/perl-MooseX-Types-DateTime-MoreCoercions-0.11-1.fc20.src.rpm
Description:
This module builds on MooseX::Types::DateTime to add additional custom
types and coercions. Since it builds on an existing type, all coercions
and constraints are inherited.

Fedora Account System Username: ppisar

Comment 1 Christopher Meng 2013-07-04 09:22:26 UTC
Do we need versioned BRs?

Comment 2 Petr Pisar 2013-07-04 12:03:34 UTC
The code does not accept any version. Without suitable version the code fails at compilation time. The build-requires just reflect constrains of package code. So it's not wrong to specify the versions.

The question if its needed is different problem. Fedora guidelines allows to omit versions if the all supported Fedora distributions provides fulfilling versions. I did not checked if the this is the case.

However keeping versions allows to port the package for different distributions (e.g. an EPEL) easily.

Also keeping versions allows automated source upgrade when the automated process starts with rigid and correct spec file, so consequent delta tests will produce minimal differences that are easy to review.

Comment 3 Christopher Meng 2013-07-26 03:45:10 UTC
Reviewed.

APPROVED.

Comment 4 Petr Pisar 2013-07-26 05:59:35 UTC
New Package SCM Request
=======================
Package Name: perl-MooseX-Types-DateTime-MoreCoercions
Short Description: Extensions to MooseX::Types::DateTime
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-07-26 11:54:25 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2013-07-26 12:19:28 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.