Bug 982987

Summary: Should add --driver parameter to nodedev-detach command in manual page
Product: Red Hat Enterprise Linux 7 Reporter: EricLee <bili>
Component: libvirtAssignee: Peter Krempa <pkrempa>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 7.0CC: acathrow, dyuan, honzhang, mzhan, pkrempa, xuzhang
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-1.1.1-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 10:11:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description EricLee 2013-07-10 09:14:04 UTC
Description:
Should add --driver to nodedev-detach command in manual page

Version:
libvirt-1.1.0-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.# man virsh
...
       nodedev-detach nodedev                        -------------------------------no "--driver" parameter
           Detach nodedev from the host, so that it can safely be used by guests via <hostdev> passthrough.  This is reversed with nodedev-reattach, and is done automatically for
           managed devices.  For compatibility purposes, this command can also be spelled nodedev-dettach.
...

2. There is --driver in help doc:
# virsh help nodedev-detach
  NAME
    nodedev-detach - detach node device from its device driver

  SYNOPSIS
    nodedev-detach <device> [--driver <string>]

  DESCRIPTION
    Detach node device from its device driver before assigning to a domain.

  OPTIONS
    [--device] <string>  device key
    --driver <string>  pci device assignment backend driver (e.g. 'vfio' or 'kvm')

Actual results:
As steps

Expected results:
Should add it.

Additional info:

Comment 2 Peter Krempa 2013-07-12 09:44:10 UTC
Patch posted upstream:

http://www.redhat.com/archives/libvir-list/2013-July/msg00788.html

Comment 3 Peter Krempa 2013-07-12 12:25:25 UTC
Fixed upstream:

commit acc27c4eaae37f128884670a7e264e344583f31d
Author: Peter Krempa <pkrempa>
Date:   Fri Jul 12 11:32:51 2013 +0200

    virsh: Mention --driver in man page for nodedev-detach
    
    https://bugzilla.redhat.com/show_bug.cgi?id=982987
    
    Commit d923f6c8 introduced the --driver option but didn't document it in
    the man page. The docs are borrowed from the public API documentation.

Comment 4 zzhong@redhat.com 2013-08-01 11:21:44 UTC
pkgs:
libvirt-1.1.1-1.el7.x86_64

steps:
1.
#man virsh 
 /nodedev-detach nodedev

 nodedev-detach nodedev [--driver backend_driver]
           Detach nodedev from the host, so that it can safely be used by guests via <hostdev> passthrough.  This is reversed
           with nodedev-reattach, and is done automatically for managed devices.  For compatibility purposes, this command
           can also be spelled nodedev-dettach.

           Different backend drivers expect the device to be bound to different dummy devices. For example, QEMU's "kvm"
           backend driver (the default) expects the device to be bound to pci-stub, but its "vfio" backend driver expects the
           device to be bound to vfio-pci. The --driver parameter can be used to specify the desired backend driver.

According above,the --driver parameter to nodedev-detach command is in manual page. So change the status to VERIFIED.

Comment 5 Ludek Smid 2014-06-13 10:11:10 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.