RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 982987 - Should add --driver parameter to nodedev-detach command in manual page
Summary: Should add --driver parameter to nodedev-detach command in manual page
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: x86_64
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-10 09:14 UTC by EricLee
Modified: 2014-06-18 00:52 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.1.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 10:11:10 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description EricLee 2013-07-10 09:14:04 UTC 
Description:
Should add --driver to nodedev-detach command in manual page

Version:
libvirt-1.1.0-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.# man virsh
...
       nodedev-detach nodedev                        -------------------------------no "--driver" parameter
           Detach nodedev from the host, so that it can safely be used by guests via <hostdev> passthrough.  This is reversed with nodedev-reattach, and is done automatically for
           managed devices.  For compatibility purposes, this command can also be spelled nodedev-dettach.
...

2. There is --driver in help doc:
# virsh help nodedev-detach
  NAME
    nodedev-detach - detach node device from its device driver

  SYNOPSIS
    nodedev-detach <device> [--driver <string>]

  DESCRIPTION
    Detach node device from its device driver before assigning to a domain.

  OPTIONS
    [--device] <string>  device key
    --driver <string>  pci device assignment backend driver (e.g. 'vfio' or 'kvm')

Actual results：
As steps

Expected results:
Should add it.

Additional info:
Comment 2 Peter Krempa 2013-07-12 09:44:10 UTC 
Patch posted upstream:

http://www.redhat.com/archives/libvir-list/2013-July/msg00788.html
Comment 3 Peter Krempa 2013-07-12 12:25:25 UTC 
Fixed upstream:

commit acc27c4eaae37f128884670a7e264e344583f31d
Author: Peter Krempa <pkrempa>
Date:   Fri Jul 12 11:32:51 2013 +0200

    virsh: Mention --driver in man page for nodedev-detach
    
    https://bugzilla.redhat.com/show_bug.cgi?id=982987
    
    Commit d923f6c8 introduced the --driver option but didn't document it in
    the man page. The docs are borrowed from the public API documentation.
Comment 4 zzhong@redhat.com 2013-08-01 11:21:44 UTC 
pkgs:
libvirt-1.1.1-1.el7.x86_64

steps:
1.
#man virsh 
 /nodedev-detach nodedev

 nodedev-detach nodedev [--driver backend_driver]
           Detach nodedev from the host, so that it can safely be used by guests via <hostdev> passthrough.  This is reversed
           with nodedev-reattach, and is done automatically for managed devices.  For compatibility purposes, this command
           can also be spelled nodedev-dettach.

           Different backend drivers expect the device to be bound to different dummy devices. For example, QEMU's "kvm"
           backend driver (the default) expects the device to be bound to pci-stub, but its "vfio" backend driver expects the
           device to be bound to vfio-pci. The --driver parameter can be used to specify the desired backend driver.

According above,the --driver parameter to nodedev-detach command is in manual page. So change the status to VERIFIED.
Comment 5 Ludek Smid 2014-06-13 10:11:10 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.