Bug 983373
| Summary: | Changing the filter while editing a translation causes save dialog error | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Zanata | Reporter: | Damian Jansen <djansen> | ||||||
| Component: | Component-Logic | Assignee: | Alex Eng <aeng> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Damian Jansen <djansen> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | development | CC: | zanata-bugs | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-11-27 03:31:14 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 978656 | ||||||||
| Attachments: |
|
||||||||
Created attachment 772023 [details]
2. Filter saving errors in history
Implemented fix. See: https://github.com/zanata/zanata-server/commit/51ad24fc2f76f5cbd91a273c9f01aacbecea9335 https://github.com/zanata/zanata-server/commit/710b4a57507c8a615cfa18a8205797358ccab9e9 Reimplementation: https://github.com/zanata/zanata-server/commit/3174b234ab15bcf4a15b27640744d1a88d98e9a4 Tested at 72079ed37970b7dbb6e8b62d3701d0933fc03d9e Looks good to me. Closing VERIFIED bugs which predate Zanata 3.1.2. |
Created attachment 772021 [details] 1. Save dialog for unsaved translation when filtering Description of problem: If a user edits a translation, and clicks a filter, a dialog will appear confirming the need to save. It appears that if the user presses Save, then changes the filter, another save dialog will appear. Clicking Save on this dialog will cause an error to show in the history. Version-Release number of selected component (if applicable): Dev How reproducible: Easily, Always Steps to Reproduce: 1. Go to a document translation 2. Edit some text in the target 3. Click a filter option 4. Click Save Changes on the dialog 5. Click a different filter option Actual results: A Save dialog appears. Pressing Save Changes causes error to appear. Expected results: No Save Changes dialog should appear. Additional info: