Bug 987915
| Summary: | Missing correlation-Id for adding new host | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Moti Asayag <masayag> | ||||
| Component: | ovirt-engine-core | Assignee: | Mooli Tayer <mtayer> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | unspecified | CC: | acathrow, bazulay, iheim, sbonazzo, yzaslavs | ||||
| Target Milestone: | m1 | ||||||
| Target Release: | 3.3.2 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | infra | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-12-19 14:24:16 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
A bug was introduces in http://gerrit.ovirt.org/#/c/15795/16 causing all commands 1.) not executed by MultipleActionRunner AND 2.) not provided with correlationId in initial parameters to not print a correlationId to the log. proposing patch upstream. Submitted under ovirt-engine-3.3 rc build done, moving to ON_QA, packages will be available on updates-testing repository. oVirt 3.3.2 has been released resolving the problem described in this bug report. |
Created attachment 777758 [details] engine.log Description of problem: A correlation id isn't created for 'Add Host' action. Without the correlation-id, it is less convenient to track the installation flow on the engine log and since setup network is used to configure the network on vdsm, that value doesn't pass to vdsm (although mostly relevant for first installation where the log file is relatively short at that point of time) Version-Release number of selected component (if applicable): How reproducible: always Steps to Reproduce: 1. Add host via the UI 2. Open engine log and track 'AddVdsCommand' Actual results: No correlation id for the command, although invoked by an external user. 2013-07-24 09:57:26,728 INFO [org.ovirt.engine.core.bll.AddVdsCommand] (ajp-- 127.0.0.1-8702-10) Running command: AddVdsCommand internal: false. Entities affected : ID: 99408929-82cf-4dc7-a532-9d998063fa95 Type: VdsGroups Expected results: 2013-07-24 09:57:26,728 INFO [org.ovirt.engine.core.bll.AddVdsCommand] (ajp-- 127.0.0.1-8702-10) Running command: AddVdsCommand internal: false. Entities affected : ID: 99408929-82cf-4dc7-a532-9d998063fa95 Type: VdsGroups Additional info: The RemoveVdsCommand which also invoked by the user does contain the correlation id. However the RemoveVdsCommand called by the UI is invoked as a MultipleAction, therefore its threads are created from the engine thread-pool-util (pool-6-thread-50) which the AddVdsCommand allocated thread is taken from other thread pool (ajp--127.0.0.1-8702). 2013-07-24 09:53:47,398 INFO [org.ovirt.engine.core.bll.RemoveVdsCommand] (pool-6-thread-50) [63a05356] Lock freed to object EngineLock [exclusiveLocks= key: a32d0adf-8f13-4f98-9d06-594c62859827 value: VDS , sharedLocks= ] 2013-07-24 09:57:26,728 INFO [org.ovirt.engine.core.bll.AddVdsCommand] (ajp--127.0.0.1-8702-10) Running command: AddVdsCommand internal: false. Entities affected : ID: 99408929-82cf-4dc7-a532-9d998063fa95 Type: VdsGroups