Bug 988065
| Summary: | Migration fails - AttributeError: 'ConsoleDevice' object has no attribute 'alias' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Martin Sivák <msivak> | ||||
| Component: | vdsm | Assignee: | Vinzenz Feenstra [evilissimo] <vfeenstr> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Haim <hateya> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | unspecified | CC: | abaron, acathrow, amuller, bazulay, danken, dfediuck, iheim, mgoldboi, michal.skrivanek, mpavlik, vfeenstr, yeylon | ||||
| Target Milestone: | --- | ||||||
| Target Release: | 3.3 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | virt | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-08-08 16:44:09 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 918494 | ||||||
| Attachments: |
|
||||||
|
Description
Martin Sivák
2013-07-24 16:06:09 UTC
assaf, I think this is again related to your change regarding "alias" Note that console devices HAS an alias. The fix should be to read it properly from the domxml, not to ignore it.
<console type='pty' tty='/dev/pts/0'>
<source path='/dev/pts/0'/>
<target type='virtio' port='0'/>
<alias name='console0'/>
</console>
Vinzenz, could you help Assaf with it?
The problem is not libvirt, libvirt does create aliases for everything, but we did not read the aliases for all devices from libvirt. For example the ConsoleDevice does not retrieve the 'underlying device info' and does not set the alias. When the migration is sent, the 'devices' dictionary does not contain an alias for the ConsoleDevice object. It also seems like that the BalloonDevice in older oVirt versions (pre 3.1) do not have an alias, which would basically break migrations from that VDSM to this one as well. I can fix it for now for ConsoleDevices by adding an alias member in the '__init__' of the class after the base class was initialized. Not a big fan, however it solves that for migrations from older versions. it doesn't solve the balloon, though http://gerrit.ovirt.org/#/c/17602/ merged u/s to master branch as http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=commit;h=e857a9d7345d17c611e23c4cc837dd191e94fe07 merged u/s to ovirt-3.3 branch as http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=commit;h=02bd2860a8eac53c1e843867fa67dc16c07b6669 -------------------------------------------------------------------- http://gerrit.ovirt.org/#/c/17515/ merged u/s to master branch as http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=commit;h=5a805bf5928cfa9aa7a4b45773dba190be1d62c7 merged u/s to ovirt-3.3 branch as http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=commit;h=127da86be3ac1330c2518e704b8bcb000ab43753 Closing as the bug has been fixed via patches merged on upstream master and ovirt-3.3 branches. *** Bug 987496 has been marked as a duplicate of this bug. *** |