Bug 988478

Summary:	Can't mco ping new nodes after upgrade - Change mcollective conf from "stomp" to "activemq"
Product:	OpenShift Container Platform	Reporter:	Luke Meyer <lmeyer>
Component:	Cluster Version Operator	Assignee:	John W. Lamb <jolamb>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	1.2.0	CC:	baulakh, bleanhar, jialiu, libra-onpremise-devel
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-enterprise-upgrade-broker-1.2.2-1 openshift-enterprise-upgrade-node-1.2.2-1	Doc Type:	Bug Fix
Doc Text:	When upgrading from OpenShift Enterprise 1.1 to 1.2 the Mcollective connector was not migrated to the new ActiveMQ connector. Instead, it still used the deprecated Stomp connector causing some nodes to not respond to 'mco ping' requests. Users are advised to verify that the connector is set to ActiveMQ in the /etc/openshift/{client,server}.cfg files on all nodes and brokers. New upgrades will be migrated to the updated configuration automatically.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-25 15:29:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luke Meyer 2013-07-25 16:33:25 UTC

Description of problem:
Our upgrade scripts do not currently make the change in mcollective connector. This is not a problem until one of two things happens:
1. A new node is created with the new instructions which specify "activemq". This will be incompatible with the existing systems - the new nodes will not even respond to mco ping.
2. We upgrade to the next version of mcollective where "stomp" is not just deprecated removed.

Steps to Reproduce:
1. Upgrade OSE 1.1 to OSE 1.2
2. Look in /etc/mcollective/server.cfg on nodes
3. Look in /etc/mcollective/client.cfg on brokers 

Actual results:

connector = stomp
plugin.stomp.pool.size = 1
plugin.stomp.pool.host1 = activemq.ose.example.com
plugin.stomp.pool.port1 = 61613
[...]

Expected results:

connector = activemq
plugin.activemq.pool.size = 1
plugin.activemq.pool.1.host = activemq.ose.example.com
plugin.activemq.pool.1.port = 61613
[...]
(Note the slight difference in format!)

Additional info:
Would be wise to add a check for the old connector in oo-diagnostics and have it refer to a helpful kbase article or at least this bug.

Comment 2 John W. Lamb 2013-09-09 21:28:19 UTC

Fix submitted here: https://github.com/openshift/enterprise/pull/30

Awaiting review

Comment 3 John W. Lamb 2013-09-10 15:55:10 UTC

Merged PR, tested against working single-server and server-pool mcollective configs.

Comment 5 Johnny Liu 2013-09-11 11:42:33 UTC

Verified this bug with the following packages, and PASS.

openshift-enterprise-upgrade-broker-1.2.2-1.el6op.noarch
openshift-enterprise-upgrade-node-1.2.2-1.el6op.noarch

Before upgrade:
# cat ~/client.cfg 
<--snip-->
connector = stomp
plugin.stomp.host = activemq.rhn.com
plugin.stomp.port = 61613
plugin.stomp.user = mcollective
plugin.stomp.password = marionette


# cat ~/server.cfg 
<--snip-->
connector = stomp
plugin.stomp.host = activemq.rhn.com
plugin.stomp.port = 61613
plugin.stomp.user = mcollective
plugin.stomp.password = marionette

After upgrade:
# cat /etc/mcollective/client.cfg
<--snip-->
connector = activemq
plugin.activemq.pool.size = 1
plugin.activemq.pool.1.host = activemq.rhn.com
plugin.activemq.pool.1.port = 61613
plugin.activemq.pool.1.user = mcollective
plugin.activemq.pool.1.password = marionette


# cat /etc/mcollective/server.cfg
<--snip-->
connector = activemq
plugin.activemq.pool.size = 1
plugin.activemq.pool.1.host = activemq.rhn.com
plugin.activemq.pool.1.port = 61613
plugin.activemq.pool.1.user = mcollective
plugin.activemq.pool.1.password = marionette


After upgrade, add a new node with the new instructions which specify "activemq"
mco ping could find this new node.

Comment 8 errata-xmlrpc 2013-09-25 15:29:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1275.html