Bug 988747

Summary: [RFE] Beakerlib functions rlAssertExists and rlAssertNotExists should differentiate between file and directory
Product: [Fedora] Fedora Reporter: Filip Holec <fholec>
Component: beakerlibAssignee: Petr Muller <pmuller>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: ohudlick, pmuller, psplicha
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: beakerlib-1.9-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-30 06:57:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1116308, 1116317    
Attachments:
Description Flags
Patch for beakerlib to modify rlAssertExists and rlAssertNotExists output message
none
Simple test none

Description Filip Holec 2013-07-26 09:48:43 UTC
Created attachment 778721 [details]
Patch for beakerlib to modify rlAssertExists and rlAssertNotExists output message

Description of problem:
Since functions rlAssertExists and rlAssertNotExists work well with directories, we should modify the output message properly.

Version-Release number of selected component (if applicable):
beakerlib-1.8

How reproducible:
Always

Steps to Reproduce:
1. Create a directory in test
2. Run rlAssertExists with directory path as argument
3. Run rlAssertNotExists with directory path as argument

Actual results:
File $dir should exist
File $dir should not exist

Expected results:
Directory $dir should exist
Directory $dir should not exist

Additional info:

Comment 1 Filip Holec 2013-07-26 09:51:51 UTC
Created attachment 778722 [details]
Simple test

Added simple beakerlib test

Comment 2 Petr Muller 2013-08-12 12:34:45 UTC
This does not need to be private

Comment 4 Petr Muller 2013-08-19 14:53:23 UTC
This brough 4 fails in the suite. Note to myself: test even trivial stuff.

Comment 5 Petr Muller 2013-08-20 13:43:22 UTC
The FILE variable should have been local, or it leaks outside, rewriting possible user setting.

https://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=d8af6aef05608d28efc3c8afc7f4fd7d5c0e92ea

Comment 6 Fedora Update System 2014-06-17 13:41:21 UTC
beakerlib-1.9-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-1.fc20

Comment 7 Fedora Update System 2014-06-17 23:28:52 UTC
Package beakerlib-1.9-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.9-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7442/beakerlib-1.9-1.fc20
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2014-07-02 08:01:01 UTC
beakerlib-1.9-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-2.fc20

Comment 9 Dalibor Pospíšil 2014-07-04 08:51:00 UTC
Please consider the package fixing this bug available in Fedora stable repos once bz1116308 is closed and RHEL stable repos once bz1116317 is closed.

Fixed in:
beakerlib-1.9-2.fc19
beakerlib-1.9-2.fc20
beakerlib-1.9-2.fc21
beakerlib-1.9-3.el5
beakerlib-1.9-2.el6
beakerlib-1.9-2.el7

Comment 10 Fedora Update System 2014-07-17 13:15:32 UTC
beakerlib-1.9-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-3.fc20

Comment 11 Fedora Update System 2014-07-30 06:57:02 UTC
beakerlib-1.9-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.