Bug 988866
| Summary: | Review Request:php-pecl-event - Provides interface to libevent library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Adam Williamson <awilliam> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | awilliam |
| Target Milestone: | --- | Flags: | awilliam:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | php-pecl-event-1.9.1-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-04 09:39:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Remi Collet
2013-07-26 15:15:24 UTC
Update to 1.7.2 Spec: https://raw.github.com/remicollet/remirepo/1a411ba23962e14ca0cbcf11c9fefe138d091e5c/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.2-1.remi.src.rpm Update to 1.7.5 https://github.com/remicollet/remirepo/commit/8a325a0f729e695738404f3f5fab494f149a3855 Spec: https://raw.github.com/remicollet/remirepo/8a325a0f729e695738404f3f5fab494f149a3855/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.5-1.remi.src.rpm Update to 1.7.6 Spec: https://raw.github.com/remicollet/remirepo/0b999cfa4b2bee100ea4386b8bb37b38802591af/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.6-1.remi.src.rpm Update to 1.7.8 Spec: https://raw.github.com/remicollet/remirepo/c19341196dc90821aef6ada07a1919429d104a15/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.8-1.remi.src.rpm Update to 1.8.0 Spec: https://raw.github.com/remicollet/remirepo/5b24e53895921a885e2f9e00f1001f4bcecf2fd7/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.8.0-1.remi.src.rpm Update to 1.8.1 (with my patch merged) Spec: https://raw.github.com/remicollet/remirepo/c7d340c4ee5a3c3cd5437306df09417ad8e4a48b/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.8.1-1.remi.src.rpm The spec linked in c#6 has a changelog indicating 1.8.1, but its Version field is still 1.8.0. Oups... I think the correct one is Spec: https://raw2.github.com/remicollet/remirepo/52e56482f197eae9301d0f67dacbb3f309d8eb69/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.8.1-1.remi.src.rpm Worth a cleanup https://github.com/remicollet/remirepo/commit/6c87aca9efeb4365bdb0a6370da1eaf74adf1fe7 Spec: https://raw2.github.com/remicollet/remirepo/6c87aca9efeb4365bdb0a6370da1eaf74adf1fe7/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.8.1-2.remi.src.rpm Update to 1.9.0 and minor cleanups https://github.com/remicollet/remirepo/commit/d08a936187097f50c0892e8942209b71e69e8fa7 Spec: https://raw2.github.com/remicollet/remirepo/d08a936187097f50c0892e8942209b71e69e8fa7/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.9.0-1.remi.src.rpm Copr test build (Fedora and EPEL-7) in http://copr.fedoraproject.org/coprs/remi/morephp/monitor/ Update to 1.9.1 (compatible with PHP 5.6) https://github.com/remicollet/remirepo/commit/25993c2a8c8d100c17b750bcb792d9910ab029a8 Spec: https://raw.githubusercontent.com/remicollet/remirepo/25993c2a8c8d100c17b750bcb792d9910ab029a8/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.9.1-1.remi.src.rpm @adam: as you are still assigned to this review, can you please proceed ? god, sorry, I completely forgot. I'll do it tomorrow. [adamw@adam SRPMS]$ rpmlint php-pecl-event-1.9.1-1.remi.src.rpm php-pecl-event.src: W: spelling-error Summary(en_US) libevent -> lib event, lib-event, enlivenment php-pecl-event.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment php-pecl-event.src: E: unknown-key GPG#00f97f56 1 packages and 0 specfiles checked; 1 errors, 2 warnings. [adamw@adam x86_64]$ rpmlint php-pecl-event-* php-pecl-event.x86_64: W: spelling-error Summary(en_US) libevent -> lib event, lib-event, enlivenment php-pecl-event.x86_64: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Those are all fine, the GPG key obviously won't happen in the Fedora build system. All MUST guidelines at https://fedoraproject.org/wiki/Packaging:ReviewGuidelines are fine. SHOULD guidelines look good too. Review is APPROVED. Is it really correct to ship the tests as docs? Maybe a separate subpackage would be better? Just a thought, not blocking review. (In reply to Adam Williamson from comment #15) > Is it really correct to ship the tests as docs? Maybe a separate subpackage > would be better? Just a thought, not blocking review. I mostly consider "tests" as "examples" of using the library, so I think providing them as %doc makes sense. I only provides tests for 2 reasons - examples - be consistent with "pecl list-files foo" For some extensions, when a -devel subpackage exists (for headers) I also put examples and tests in this subpackage. Or when test suite is very large. Thanks for the review. New Package SCM Request ======================= Package Name: php-pecl-event Short Description: Provides interface to libevent library Owners: remi Branches: f20 epel7 InitialCC: Git done (by process-git-requests). php-pecl-event-1.9.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-pecl-event-1.9.1-1.fc20 php-pecl-event-1.9.1-1.fc20 has been pushed to the Fedora 20 testing repository. php-pecl-event-1.9.1-1.fc20 has been pushed to the Fedora 20 stable repository. |