Bug 988866 - Review Request:php-pecl-event - Provides interface to libevent library
Summary: Review Request:php-pecl-event - Provides interface to libevent library
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adam Williamson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-26 15:15 UTC by Remi Collet
Modified: 2014-04-04 09:39 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2014-04-04 09:39:48 UTC
awilliam: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Remi Collet 2013-07-26 15:15:24 UTC
Spec URL: https://raw.github.com/remicollet/remirepo/af464cdc477c529ee2e1b22c37d4b14388b0159a/php/pecl/php-pecl-event/php-pecl-event.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.1-2.remi.src.rpm
Description: 
This is an extension to efficiently schedule I/O, time and signal based
events using the best I/O notification mechanism available for specific
platform. This is a port of libevent to the PHP infrastructure.

Version 1.0.0 introduces:
* new OO API breaking backwards compatibility
* support of libevent 2+ including HTTP, DNS, OpenSSL and the event listener.

Fedora Account System Username: remi

Comment 7 Adam Williamson 2014-01-10 23:45:14 UTC
The spec linked in c#6 has a changelog indicating 1.8.1, but its Version field is still 1.8.0.

Comment 11 Remi Collet 2014-01-17 08:07:26 UTC
Copr test build (Fedora and EPEL-7) in http://copr.fedoraproject.org/coprs/remi/morephp/monitor/

Comment 13 Remi Collet 2014-03-23 08:18:54 UTC
@adam: as you are still assigned to this review, can you please proceed ?

Comment 14 Adam Williamson 2014-03-23 16:01:10 UTC
god, sorry, I completely forgot. I'll do it tomorrow.

Comment 15 Adam Williamson 2014-03-25 19:56:33 UTC
[adamw@adam SRPMS]$ rpmlint php-pecl-event-1.9.1-1.remi.src.rpm 
php-pecl-event.src: W: spelling-error Summary(en_US) libevent -> lib event, lib-event, enlivenment
php-pecl-event.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment
php-pecl-event.src: E: unknown-key GPG#00f97f56
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
[adamw@adam x86_64]$ rpmlint php-pecl-event-*
php-pecl-event.x86_64: W: spelling-error Summary(en_US) libevent -> lib event, lib-event, enlivenment
php-pecl-event.x86_64: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Those are all fine, the GPG key obviously won't happen in the Fedora build system.

All MUST guidelines at https://fedoraproject.org/wiki/Packaging:ReviewGuidelines are fine. SHOULD guidelines look good too. Review is APPROVED.

Is it really correct to ship the tests as docs? Maybe a separate subpackage would be better? Just a thought, not blocking review.

Comment 16 Remi Collet 2014-03-26 05:30:04 UTC
(In reply to Adam Williamson from comment #15)
> Is it really correct to ship the tests as docs? Maybe a separate subpackage
> would be better? Just a thought, not blocking review.

I mostly consider "tests" as "examples" of using the library, so I think providing them as %doc makes sense.

I only provides tests for 2 reasons
- examples
- be consistent with "pecl list-files foo"

For some extensions, when a -devel subpackage exists (for headers) I also put examples and tests in this subpackage. Or when test suite is very large.


Thanks for the review.

Comment 17 Remi Collet 2014-03-26 05:31:00 UTC
New Package SCM Request
=======================
Package Name: php-pecl-event
Short Description: Provides interface to libevent library
Owners: remi
Branches: f20 epel7
InitialCC:

Comment 18 Gwyn Ciesla 2014-03-26 12:01:51 UTC
Git done (by process-git-requests).

Comment 19 Fedora Update System 2014-03-26 12:59:44 UTC
php-pecl-event-1.9.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-pecl-event-1.9.1-1.fc20

Comment 20 Fedora Update System 2014-03-27 04:42:25 UTC
php-pecl-event-1.9.1-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 21 Fedora Update System 2014-04-04 09:39:48 UTC
php-pecl-event-1.9.1-1.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.