Bug 988890
| Summary: | Review Request: rubygem-sass-twitter-bootstrap - Gem of the Twitter Bootstrap | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mmahut, notting, package-review, tdawson |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-10 03:57:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 894524 | ||
|
Description
Troy Dawson
2013-07-26 15:49:34 UTC
RPMLINT VALUES: $ rpmlint rubygem-sass-twitter-bootstrap.spec rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.src.rpm rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.noarch.rpm rubygem-sass-twitter-bootstrap-doc-2.0.1-1.fc20.noarch.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. REASON FOR OLDER VERSION OF GEM: This package is for a couple of OpenShift packages that need this version. Upstream will not be able to update and test to the newer version of this gem for several months. There have been no security advisories about this gem that require the newer versions. REASON FOR THE VENDOR DIRECTORY: We are following the footsteps of the rubygem-bootstrap-sass review[1]. That review consulted with the ruby-sig and the consensus was to leave the bundled javascript in until there are approved javascript guidelines.[2] [1] https://bugzilla.redhat.com/show_bug.cgi?id=982679 [2] https://lists.fedoraproject.org/pipermail/ruby-sig/2013-July/001389.html LICENSE: The License is already in newer versions of the gem. When we are able to update to a newer version, we will use Upstreams file. Troy, Thank you for this review request. I think you're missing ruby(abi) in your Requires. Other than that, this package looks fine to me. I'm attaching the scratch builds too. rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=5671036 f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5671048 f19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5671046 ruby(abi) was replaced in Fedora 19 with ruby(release), which is in the spec file. I chose to not have a version (which is recommended) because there isn't anything to indicate it needs a version. https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Ruby_Compatibility Troy, good to know :) I missed that update. This review request is approved. New Package SCM Request ======================= Package Name: rubygem-sass-twitter-bootstrap Short Description: Gem of the Twitter Bootstrap Owners: tdawson Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 testing repository. rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository. rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository. |