Bug 988890 - Review Request: rubygem-sass-twitter-bootstrap - Gem of the Twitter Bootstrap
Summary: Review Request: rubygem-sass-twitter-bootstrap - Gem of the Twitter Bootstrap
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 894524
TreeView+ depends on / blocked
 
Reported: 2013-07-26 15:49 UTC by Troy Dawson
Modified: 2013-08-10 12:37 UTC (History)
4 users (show)

Fixed In Version: rubygem-sass-twitter-bootstrap-2.0.1-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-10 03:57:26 UTC
mmahut: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Troy Dawson 2013-07-26 15:49:34 UTC
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-sass-twitter-bootstrap.spec
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.src.rpm
Description: A rails compatible gem for John Long's Sass conversion 
of the Twitter Bootstrap
Fedora Account System Username: tdawson

Comment 1 Troy Dawson 2013-07-26 16:04:58 UTC
RPMLINT VALUES:
$ rpmlint rubygem-sass-twitter-bootstrap.spec rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.src.rpm rubygem-sass-twitter-bootstrap-2.0.1-1.fc20.noarch.rpm rubygem-sass-twitter-bootstrap-doc-2.0.1-1.fc20.noarch.rpm
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

REASON FOR OLDER VERSION OF GEM:
This package is for a couple of OpenShift packages that need this version.  Upstream will not be able to update and test to the newer version of this gem for several months.  There have been no security advisories about this gem that require the newer versions.

REASON FOR THE VENDOR DIRECTORY:
We are following the footsteps of the rubygem-bootstrap-sass review[1].  That review consulted with the ruby-sig and the consensus was to leave the bundled javascript in until there are approved javascript guidelines.[2]
[1] https://bugzilla.redhat.com/show_bug.cgi?id=982679
[2] https://lists.fedoraproject.org/pipermail/ruby-sig/2013-July/001389.html

LICENSE:
The License is already in newer versions of the gem.  When we are able to update to a newer version, we will use Upstreams file.

Comment 2 Marek Mahut 2013-07-29 08:54:30 UTC
Troy,

Thank you for this review request. 

I think you're missing ruby(abi) in your Requires.

Other than that, this package looks fine to me. I'm attaching the scratch builds too.

  rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=5671036
  f20     http://koji.fedoraproject.org/koji/taskinfo?taskID=5671048
  f19     http://koji.fedoraproject.org/koji/taskinfo?taskID=5671046

Comment 3 Troy Dawson 2013-07-29 15:24:52 UTC
ruby(abi) was replaced in Fedora 19 with ruby(release), which is in the spec file.
I chose to not have a version (which is recommended) because there isn't anything to indicate it needs a version.

https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Ruby_Compatibility

Comment 4 Marek Mahut 2013-07-30 08:34:34 UTC
Troy, good to know :) I missed that update. This review request is approved.

Comment 5 Troy Dawson 2013-07-30 13:36:38 UTC
New Package SCM Request
=======================
Package Name: rubygem-sass-twitter-bootstrap
Short Description: Gem of the Twitter Bootstrap
Owners: tdawson
Branches: f18 f19 el6
InitialCC:

Comment 6 Gwyn Ciesla 2013-07-30 13:43:34 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-07-30 14:34:44 UTC
rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-sass-twitter-bootstrap-2.0.1-1.fc19

Comment 8 Fedora Update System 2013-08-02 03:44:08 UTC
rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-08-10 03:57:26 UTC
rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 10 Fedora Update System 2013-08-10 12:37:42 UTC
rubygem-sass-twitter-bootstrap-2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.