Bug 989846

Summary:	Rebalance/remove-brick:Treat migration failures due to space constraints as skipped
Product:	[Community] GlusterFS	Reporter:	shishir gowda <sgowda>
Component:	distribute	Assignee:	Nagaprasad Sathyanarayana <nsathyan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	asriram, gluster-bugs, nsathyan, rwheeler, sdharane, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	990562 998077 (view as bug list)		Environment:
Last Closed:	2014-04-17 13:13:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	990562, 998077

Description shishir gowda 2013-07-30 04:21:55 UTC

Description of problem:
Currently when files are ignored/skipped for migration due to space constraints (destination does not have enough space or migration leads to imbalance in cluster), we treat them as failures too. These files are shown as failures in the cli output(status)

We need to separate these out, and treat them correctly as ignored/skipped to prevent users from getting worried with the failure counts.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-07-30 04:27:59 UTC

REVIEW: http://review.gluster.org/5399 (cluster/dht: Treat migration failures due to space constraints as skipped) posted (#3) for review on master by Shishir Gowda (sgowda)

Comment 2 Anand Avati 2013-07-31 03:52:49 UTC

REVIEW: http://review.gluster.org/5399 (cluster/dht: Treat migration failures due to space constraints as skipped) posted (#4) for review on master by Shishir Gowda (sgowda)

Comment 3 Anand Avati 2013-07-31 06:56:38 UTC

COMMIT: http://review.gluster.org/5399 committed in master by Vijay Bellur (vbellur) 
------
commit e306698b00d2d3e736cbc97a1383bfb5d3724796
Author: shishir gowda <sgowda>
Date:   Fri Jul 26 11:59:12 2013 +0530

    cluster/dht: Treat migration failures due to space constraints as skipped
    
    Currently rebalance/remove-brick op's display migration failed count even
    for files which failed due to space issues (not enough space for file, or
    migration leading to cluster imbalance)
    
    These will now be counted as skipped, and rebalance/remove-brick status
    will display the additional counter
    
    Change-Id: I674904d380b5f8300e9ca9e6af557c3d30d6cff4
    BUG: 989846
    Signed-off-by: shishir gowda <sgowda>
    Reviewed-on: http://review.gluster.org/5399
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2013-07-31 13:44:34 UTC

REVIEW: http://review.gluster.org/5446 (cluster/dht: Re-initialize skipped file count in glusterd) posted (#1) for review on master by Shishir Gowda (sgowda)

Comment 5 Anand Avati 2013-07-31 20:27:52 UTC

COMMIT: http://review.gluster.org/5446 committed in master by Anand Avati (avati) 
------
commit 691b973704b4ba511b295ee6f8baf1c4a1d8d89c
Author: shishir gowda <sgowda>
Date:   Wed Jul 31 19:09:52 2013 +0530

    cluster/dht: Re-initialize skipped file count in glusterd
    
    Change-Id: I42d08b3a6a7a3839f5e9953e1f83959222c080f8
    Signed-off-by: shishir gowda <sgowda>
    BUG: 989846
    Reviewed-on: http://review.gluster.org/5446
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Anand Avati 2013-08-16 23:34:53 UTC

REVIEW: http://review.gluster.org/5642 (dht: Print decoded errno's along with failures during rebalance) posted (#1) for review on master by Harshavardhana (harsha)

Comment 7 Anand Avati 2013-09-20 05:53:42 UTC

REVIEW: http://review.gluster.org/5977 (cluster/dht: Treat migration failures due to space constraints as skipped) posted (#1) for review on release-3.4 by Shishir Gowda (sgowda)

Comment 8 Anand Avati 2013-09-20 06:40:25 UTC

COMMIT: http://review.gluster.org/5977 committed in release-3.4 by Anand Avati (avati) 
------
commit 04163fc4ba5c66099c0d0c764c146f2f15f40cda
Author: shishir gowda <sgowda>
Date:   Fri Sep 20 11:10:09 2013 +0530

    cluster/dht: Treat migration failures due to space constraints as skipped
    
    Currently rebalance/remove-brick op's display migration failed count even
    for files which failed due to space issues (not enough space for file, or
    migration leading to cluster imbalance)
    
    These will now be counted as skipped, and rebalance/remove-brick status
    will display the additional counter
    
    BUG: 989846
    Change-Id: I4efa7ce69dd43680ff47181afed0c561954c5080
    Signed-off-by: shishir gowda <sgowda>
    Reviewed-on: http://review.gluster.org/5977
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 11 Niels de Vos 2014-04-17 13:13:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.4.3, please reopen this bug report.

glusterfs-3.4.3 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.4.3. In the same line the recent release i.e. glusterfs-3.5.0 [3] likely to have the fix. You can verify this by reading the comments in this bug report and checking for comments mentioning "committed in release-3.5".

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137