Bug 990815
| Summary: | Review Request: x2godesktopsharing - Share X2go desktops with other users | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-31 04:17:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 969220 | ||
| Bug Blocks: | 998551 | ||
|
Description
Orion Poplawski
2013-08-01 04:11:17 UTC
1. "install -p" the icons. 2. Update icon cache script is missing Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing-3.1.1.0-2.fc19.src.rpm * Thu Aug 1 2013 Orion Poplawski <orion.com> - 3.1.1.0-2 - Create x2godesktopsharing group - Preserve timestamps on install - Update icon cache E: description-line-too-long C x2godesktopsharing is an X2Go add-on tool that allows a user to grant other X2Go users x2godesktopsharing.i686: E: non-standard-executable-perm /usr/bin/x2godesktopsharing 0775L x2godesktopsharing.i686: E: incorrect-fsf-address /usr/share/doc/x2godesktopsharing/COPYING x2godesktopsharing.i686: W: desktopfile-without-binary /usr/share/applications/x2godesktopsharing.desktop /usr/bin/x2godesktopsharing(See E#1) Once fixed, this will get approved. (In reply to Christopher Meng from comment #3) > E: description-line-too-long C x2godesktopsharing is an X2Go add-on tool > that allows a user to grant other X2Go users > x2godesktopsharing.i686: E: non-standard-executable-perm > /usr/bin/x2godesktopsharing 0775L > x2godesktopsharing.i686: E: incorrect-fsf-address > /usr/share/doc/x2godesktopsharing/COPYING Fixed. > x2godesktopsharing.i686: W: desktopfile-without-binary > /usr/share/applications/x2godesktopsharing.desktop > /usr/bin/x2godesktopsharing(See E#1) This looks to be another bug in rpmlint - it can't handle a binary with full path in Exec, but that is allowed. > > Once fixed, this will get approved. Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing-3.1.1.0-3.fc19.src.rpm * Thu Aug 1 2013 Orion Poplawski <orion.com> - 3.1.1.0-3 - Fix description formatting - Install scripts with correct permissions - Fix FSF address Congrats, APPROVED. Thanks for the review. New Package SCM Request ======================= Package Name: x2godesktopsharing Short Description: Share X2go desktops with other users Owners: orion Branches: f19 f18 el6 InitialCC: Git done (by process-git-requests). Checked in and built |