Bug 990815 - Review Request: x2godesktopsharing - Share X2go desktops with other users
Review Request: x2godesktopsharing - Share X2go desktops with other users
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Christopher Meng
Fedora Extras Quality Assurance
:
Depends On: 969220
Blocks: 998551
  Show dependency treegraph
 
Reported: 2013-08-01 00:11 EDT by Orion Poplawski
Modified: 2013-10-19 17:12 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-08-31 00:17:30 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
i: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Orion Poplawski 2013-08-01 00:11:17 EDT
Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing-3.1.1.0-1.fc19.src.rpm
Description: 
x2godesktopsharing is an X2go add-on tool that allows a user to grant other X2go users
access to the current session (shadow session support).


Fedora Account System Username: orion
Comment 1 Christopher Meng 2013-08-01 00:15:44 EDT
1. "install -p" the icons.

2. Update icon cache script is missing
Comment 2 Orion Poplawski 2013-08-01 15:59:36 EDT
Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing-3.1.1.0-2.fc19.src.rpm

* Thu Aug 1 2013 Orion Poplawski <orion@cora.nwra.com> - 3.1.1.0-2
- Create x2godesktopsharing group
- Preserve timestamps on install
- Update icon cache
Comment 3 Christopher Meng 2013-08-01 23:37:58 EDT
E: description-line-too-long C x2godesktopsharing is an X2Go add-on tool that allows a user to grant other X2Go users
x2godesktopsharing.i686: E: non-standard-executable-perm /usr/bin/x2godesktopsharing 0775L
x2godesktopsharing.i686: E: incorrect-fsf-address /usr/share/doc/x2godesktopsharing/COPYING
x2godesktopsharing.i686: W: desktopfile-without-binary /usr/share/applications/x2godesktopsharing.desktop /usr/bin/x2godesktopsharing(See E#1)

Once fixed, this will get approved.
Comment 4 Orion Poplawski 2013-08-02 00:30:01 EDT
(In reply to Christopher Meng from comment #3)
> E: description-line-too-long C x2godesktopsharing is an X2Go add-on tool
> that allows a user to grant other X2Go users
> x2godesktopsharing.i686: E: non-standard-executable-perm
> /usr/bin/x2godesktopsharing 0775L
> x2godesktopsharing.i686: E: incorrect-fsf-address
> /usr/share/doc/x2godesktopsharing/COPYING

Fixed.

> x2godesktopsharing.i686: W: desktopfile-without-binary
> /usr/share/applications/x2godesktopsharing.desktop
> /usr/bin/x2godesktopsharing(See E#1)

This looks to be another bug in rpmlint - it can't handle a binary with full path in Exec, but that is allowed.

> 
> Once fixed, this will get approved.

Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/x2godesktopsharing-3.1.1.0-3.fc19.src.rpm

* Thu Aug 1 2013 Orion Poplawski <orion@cora.nwra.com> - 3.1.1.0-3
- Fix description formatting
- Install scripts with correct permissions
- Fix FSF address
Comment 5 Christopher Meng 2013-08-02 00:36:02 EDT
Congrats, APPROVED.
Comment 6 Orion Poplawski 2013-08-02 00:57:10 EDT
Thanks for the review.

New Package SCM Request
=======================
Package Name: x2godesktopsharing
Short Description: Share X2go desktops with other users
Owners: orion
Branches: f19 f18 el6
InitialCC:
Comment 7 Jon Ciesla 2013-08-02 08:01:45 EDT
Git done (by process-git-requests).
Comment 8 Orion Poplawski 2013-08-31 00:17:30 EDT
Checked in and built

Note You need to log in before you can comment on or make changes to this bug.