Bug 990887
| Summary: | nfs: crash in update 5 bits | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | rjoseph |
| Component: | nfs | Assignee: | rjoseph |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | urgent | Docs Contact: | |
| Priority: | high | ||
| Version: | mainline | CC: | bhubbard, fharshav, gluster-bugs, rhs-bugs, saujain, sdharane, shaines, spradhan, vagarwal, vbellur |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 969372 | Environment: | |
| Last Closed: | 2014-04-17 11:45:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 969372 | ||
| Bug Blocks: | |||
|
Comment 1
Anand Avati
2013-08-01 07:38:44 UTC
REVIEW: http://review.gluster.org/5452 (nfs: Fix for NFS crash during blocking NLM call.) posted (#2) for review on master by Rajesh Joseph (rjoseph) COMMIT: http://review.gluster.org/5452 committed in master by Vijay Bellur (vbellur) ------ commit 6235e8e956ce6d72c88ddb3ad81c0842ee4d089c Author: Rajesh Joseph <rjoseph> Date: Thu Aug 1 12:55:51 2013 +0530 nfs: Fix for NFS crash during blocking NLM call. Bug 990887: During a blocking NLM call NFS server is crashing. Cause: When nlm4_establish_callback function is called from nlm4svc_send_granted the cs->req->trans pointer is NULL. Thus using this pointer will result in a crash. Whereas cs->trans points to a valid transport object. NLM should use cs->trans instead of cs->req->trans. Fix: Replaced cs->req->trans with cs->trans. Change-Id: I425e48e0aafc9a6c130912edf2e801d8c4c9472d BUG: 990887 Signed-off-by: Rajesh Joseph <rjoseph> Reviewed-on: http://review.gluster.org/5452 Reviewed-by: Amar Tumballi <amarts> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/7478 (nfs: Fix for NFS crash during blocking NLM call.) posted (#1) for review on release-3.4 by Justin Clift (justin) COMMIT: http://review.gluster.org/7478 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) ------ commit c1c7ae92a2b6bb7d57270fadd7a5d61c90fa3781 Author: Rajesh Joseph <rjoseph> Date: Thu Aug 1 12:55:51 2013 +0530 nfs: Fix for NFS crash during blocking NLM call. Bug 990887: During a blocking NLM call NFS server is crashing. Cause: When nlm4_establish_callback function is called from nlm4svc_send_granted the cs->req->trans pointer is NULL. Thus using this pointer will result in a crash. Whereas cs->trans points to a valid transport object. NLM should use cs->trans instead of cs->req->trans. Fix: Replaced cs->req->trans with cs->trans. Backport of: http://review.gluster.org/#/c/5452/ BUG: 990887 Change-Id: I33d4b6634752333d6791b1a47ebf10c787c22120 Signed-off-by: Justin Clift <justin> Reviewed-on: http://review.gluster.org/7478 Reviewed-by: Harshavardhana <harsha> Reviewed-by: Kaleb KEITHLEY <kkeithle> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |