Bug 991329

Summary:	make hdr[1051] (RPMTAG_NOSOURCE) format consistent
Product:	[Fedora] Fedora	Reporter:	Daniel Mach <dmach>
Component:	rpm	Assignee:	Panu Matilainen <pmatilai>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	ffesti, jzeleny, novyjindrich, packaging-team-maint, pknirsch, pmatilai, tmlcoch
Target Milestone:	---	Keywords:	Upstream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rpm-4.11.2-1.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-20 13:56:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	578256

Description Daniel Mach 2013-08-02 07:27:43 UTC

RPMTAG_NOSOURCE and RPMTAG_NOPATCH should always be a list - either empty or with list of relevant source/patch numbers

Current result:

src:
hdr[1051] = []

nosrc #1:
Source0: ...
NoSource: 0
hdr[1051] = 0

nosrc #2:
Source0: ...
Source1: ...
NoSource: 0
NoSource: 1
hdr[1051] = [0, 1]


Expected result:
hdr[1051] in nosrc #1 should be [0] instead of 0.

Comment 1 Panu Matilainen 2013-08-02 07:38:22 UTC

Fixed upstream now: http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=eb3e20b5f40ca69790d1cc0b6a18beec109f7c9c

Comment 2 Fedora End Of Life 2013-09-16 16:49:22 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 3 Daniel Mach 2013-10-09 08:19:02 UTC

Panu, is this usage correct?

Source0:        source0
Source1:        source1

Patch0:         patch0
Patch1:         patch1

NoSource:       0
NoSource:       1

NoPatch:        0
NoPatch:        1

this is what I get when I read the headers:
print header[rpm.RPMTAG_NOSOURCE]
print header[rpm.RPMTAG_NOPATCH]

->
0
0

Expected result:
[0, 1]
[0, 1]

Comment 4 Panu Matilainen 2013-10-09 12:20:01 UTC

The expected result is what you get with the fix in place, but its not in Fedora yet.

The header actually contains [0, 1] for both tags in this case, but the python bindings never return an array unless the tag is explicitly marked as an array type, just like a tag marked as array always returns an array regardless of the number of entries.

Comment 5 Panu Matilainen 2014-01-20 13:56:38 UTC

Fixed in rawhide now as of rpm >= 4.11.2, F20 (and F19) will be rebased to this version too once its gotten sufficient testing.

Comment 6 Fedora Update System 2014-02-13 09:02:17 UTC

rpm-4.11.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rpm-4.11.2-1.fc20

Comment 7 Fedora Update System 2014-02-13 09:44:03 UTC

rpm-4.11.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rpm-4.11.2-1.fc19

Comment 8 Fedora Update System 2014-02-16 23:22:10 UTC

rpm-4.11.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2014-04-09 01:00:41 UTC

rpm-4.11.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.