Bug 991329 - make hdr[1051] (RPMTAG_NOSOURCE) format consistent
Summary: make hdr[1051] (RPMTAG_NOSOURCE) format consistent
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: 20
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 578256
TreeView+ depends on / blocked
Reported: 2013-08-02 07:27 UTC by Daniel Mach
Modified: 2014-04-09 01:00 UTC (History)
7 users (show)

Fixed In Version: rpm-4.11.2-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-01-20 13:56:38 UTC
Type: Bug

Attachments (Terms of Use)

Description Daniel Mach 2013-08-02 07:27:43 UTC
RPMTAG_NOSOURCE and RPMTAG_NOPATCH should always be a list - either empty or with list of relevant source/patch numbers

Current result:

hdr[1051] = []

nosrc #1:
Source0: ...
NoSource: 0
hdr[1051] = 0

nosrc #2:
Source0: ...
Source1: ...
NoSource: 0
NoSource: 1
hdr[1051] = [0, 1]

Expected result:
hdr[1051] in nosrc #1 should be [0] instead of 0.

Comment 2 Fedora End Of Life 2013-09-16 16:49:22 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:

Comment 3 Daniel Mach 2013-10-09 08:19:02 UTC
Panu, is this usage correct?

Source0:        source0
Source1:        source1

Patch0:         patch0
Patch1:         patch1

NoSource:       0
NoSource:       1

NoPatch:        0
NoPatch:        1

this is what I get when I read the headers:
print header[rpm.RPMTAG_NOSOURCE]
print header[rpm.RPMTAG_NOPATCH]


Expected result:
[0, 1]
[0, 1]

Comment 4 Panu Matilainen 2013-10-09 12:20:01 UTC
The expected result is what you get with the fix in place, but its not in Fedora yet.

The header actually contains [0, 1] for both tags in this case, but the python bindings never return an array unless the tag is explicitly marked as an array type, just like a tag marked as array always returns an array regardless of the number of entries.

Comment 5 Panu Matilainen 2014-01-20 13:56:38 UTC
Fixed in rawhide now as of rpm >= 4.11.2, F20 (and F19) will be rebased to this version too once its gotten sufficient testing.

Comment 6 Fedora Update System 2014-02-13 09:02:17 UTC
rpm-4.11.2-1.fc20 has been submitted as an update for Fedora 20.

Comment 7 Fedora Update System 2014-02-13 09:44:03 UTC
rpm-4.11.2-1.fc19 has been submitted as an update for Fedora 19.

Comment 8 Fedora Update System 2014-02-16 23:22:10 UTC
rpm-4.11.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2014-04-09 01:00:41 UTC
rpm-4.11.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.