Bug 991598

Summary:	StorageNodeManager.updateConfiguration(config) returns false when it should return true.
Product:	[JBoss] JBoss Operations Network	Reporter:	Varun Khurana <vkhurana>
Component:	CLI	Assignee:	Stefan Negrea <snegrea>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	JON 3.2	CC:	ckannan, mkoci, snegrea
Target Milestone:	ER01
Target Release:	JON 3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	951619

Description Varun Khurana 2013-08-02 20:52:01 UTC

Description of problem:
StorageNodeManager.updateConfiguration(config) returns false when it should return true and the server goes into maintaineance mode.


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Connect to RHQ remote API.

2. Execute the following commands in order

var criteria = new StorageNodeCriteria();

var nodes = StorageNodeManager.findStorageNodesByCriteria(criteria);

var node = nodes.get(0);

var config = StorageNodeManager.retrieveConfiguration(node)

config.setHeapSize(<some string value say 700M or 1G etc.>)

StorageNodeManager.updateConfiguration(config)

Actual results:
It returns false in command line and the server goes into maintaineance mode

Expected results:
It should return true and the server should not go into maintaineance mode.

Additional info:

Comment 1 Stefan Negrea 2013-08-10 00:46:53 UTC

Please retest. This has been corrected by the recent changes done to the way cluster connectivity is reported.

Comment 2 jvlasak 2013-08-13 16:43:35 UTC

CLI allows to set Heap New Size value >= Heap Size value which causes that cassandra is shutting down and server stays in maintenance mode after that.

To start storage node it is necessary to set Heap New Size < Heap Size - found out experimentally setting up -Xmx -Xmn values in cassandra-jvm.properties file).


CLI commands to create the situtation:

var crit = new StorageNodeCriteria();
var nodes = StorageNodeManager.findStorageNodesByCriteria(crit);
var node = nodes.get(0);
var config = StorageNodeManager.retrieveConfiguration(node);

var heapSizeValue = "700M";
var heapNewSizeValue = "700M";  // 700M or higher value

config.setHeapSize(heapSizeValue);
config.setHeapNewSize(heapNewSizeValue);

StorageNodeManager.updateConfiguration(config);

Comment 3 Stefan Negrea 2013-08-14 20:44:50 UTC

Added SLSB validation for heap settings and jmx port settings.

master commit:
https://git.fedorahosted.org/cgit/rhq/rhq.git/commit/modules/enterprise/server/jar/src/main/java/org/rhq?id=c50b47c2ba50ddc9640ec6060313e36aaa86b44f

Comment 4 jvlasak 2013-08-19 13:21:39 UTC

verified