Bug 992807
| Summary: | pngquant: FTBFS in rawhide | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> | ||||
| Component: | pngquant | Assignee: | Björn 'besser82' Esser <besser82> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | besser82, rc040203 | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | pngquant-2.0.0-1.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-09-02 11:12:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 989991 | ||||||
| Bug Blocks: | 991858 | ||||||
| Attachments: |
|
||||||
|
Description
Dennis Gilmore
2013-08-05 06:36:17 UTC
Created attachment 789461 [details]
tarball with patches to fix the FTBFS
This package suffers from several issues.
The immediate cause for the FTBFS type clashes/incompatibility of this package with libpng-1.6.
Also, this package doesn't honoring RPM_OPT_FLAGS (weird/broken Makefile/buildinfrastructure) and for reasons I do not understand is being built with hardend-cflags (Doesn't make any sense, IMO).
I intend to apply the attached patch, which is supposed to resolve all of the issues, later today.
Thanks for the patch Ralph! Yesterday upstream released v2.0.0 which, besides other stuff, addresses the issues with libpng-1.6. see rhbz# 989991 So I'll update the package to v2.0.0 and take in all your proposed changes during today. (In reply to Björn "besser82" Esser from comment #2) > Thanks for the patch Ralph! Yesterday upstream released v2.0.0 which, > besides other stuff, addresses the issues with libpng-1.6. see rhbz# 989991 Openly said, the *-libpng16.patch is a back port of what is in 2.0.0. I don't know if the other patches will work with 2.0.0, because I noticed upstream has added a recursive subdir Makefile. I guess, I don't have to mention what I think of upstream's Makefiles ;) I'm currently working on a patch for getting upstream's recursive Make-crap working ;) Actually I offered upstream to autotoolify this and he agreed. So I think next release of pngquant (2.0.1 or so) will be ship some autotools-based build-sys. I'm not a friend of autotools, but it will be far better compared to now :) You agree with me to build libimagequant a so-lib and ship it in a seperate subpkg "libimagequant"? This is the intention about how to get it done with autotools, too. Ping? This FTBFS still persists. I'd suggest, I'd apply my patch such that this bug can be closed. I don't think this would be a problem to you, because this should not affect your autotool-/upgrading-activities and would take the pressure off from you. pong! I'm actually ready to push 2.0.0 (patched Makefiles) with building a so-lib (shipped in sub-pkg "libimgquant"). I just waited on some reply from you, Ralf, on comment #4. It's your package ... If you feel confident enough about, ... go ahead. pngquant-2.0.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.fc19 pngquant-2.0.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.fc18 pngquant-2.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.el6 pngquant-2.0.0-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.el5 (In reply to Ralf Corsepius from comment #5) > Ping? This FTBFS still persists. > > I'd suggest, I'd apply my patch such that this bug can be closed. Previously mentioned updates have been successfuly build on F20 and rawhide, too. This can be closed now. :) pngquant-2.0.0-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. pngquant-2.0.0-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. pngquant-2.0.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. pngquant-2.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |