Bug 992807 - pngquant: FTBFS in rawhide
Summary: pngquant: FTBFS in rawhide
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pngquant
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Björn 'besser82' Esser
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 989991
Blocks: F20FTBFS
TreeView+ depends on / blocked
 
Reported: 2013-08-05 06:36 UTC by Dennis Gilmore
Modified: 2013-09-23 18:13 UTC (History)
2 users (show)

Fixed In Version: pngquant-2.0.0-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-02 11:12:42 UTC
Type: ---


Attachments (Terms of Use)
tarball with patches to fix the FTBFS (2.86 KB, application/x-xz)
2013-08-23 06:14 UTC, Ralf Corsepius
no flags Details

Description Dennis Gilmore 2013-08-05 06:36:17 UTC
Your package pngquant failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=5750638

Build logs:
root.log: http://kojipkgs.fedoraproject.org/work/tasks/638/5750638/root.log
build.log: http://kojipkgs.fedoraproject.org/work/tasks/638/5750638/build.log
state.log: http://kojipkgs.fedoraproject.org/work/tasks/638/5750638/state.log
NOTE: build logs are cleaned up after 1 week

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild

Comment 1 Ralf Corsepius 2013-08-23 06:14:30 UTC
Created attachment 789461 [details]
tarball with patches to fix the FTBFS

This package suffers from several issues.

The immediate cause for the FTBFS type clashes/incompatibility of this package with libpng-1.6.

Also, this package doesn't honoring RPM_OPT_FLAGS (weird/broken Makefile/buildinfrastructure) and for reasons I do not understand is being built with hardend-cflags (Doesn't make any sense, IMO).

I intend to apply the attached patch, which is supposed to resolve all of the issues, later today.

Comment 2 Björn 'besser82' Esser 2013-08-23 08:52:23 UTC
Thanks for the patch Ralph!  Yesterday upstream released v2.0.0 which, besides other stuff, addresses the issues with libpng-1.6. see rhbz# 989991

So I'll update the package to v2.0.0 and take in all your proposed changes during today.

Comment 3 Ralf Corsepius 2013-08-23 09:42:09 UTC
(In reply to Björn "besser82" Esser from comment #2)
> Thanks for the patch Ralph!  Yesterday upstream released v2.0.0 which,
> besides other stuff, addresses the issues with libpng-1.6. see rhbz# 989991
Openly said, the *-libpng16.patch is a back port of what is in 2.0.0.

I don't know if the other patches will work with 2.0.0, because I noticed upstream has added a recursive subdir Makefile. I guess, I don't have to mention what I think of upstream's Makefiles ;)

Comment 4 Björn 'besser82' Esser 2013-08-23 09:56:25 UTC
I'm currently working on a patch for getting upstream's recursive Make-crap working ;)  Actually I offered upstream to autotoolify this and he agreed.  So I think next release of pngquant (2.0.1 or so) will be ship some autotools-based build-sys.  I'm not a friend of autotools, but it will be far better compared to now :)

You agree with me to build libimagequant a so-lib and ship it in a seperate subpkg "libimagequant"?  This is the intention about how to get it done with autotools, too.

Comment 5 Ralf Corsepius 2013-08-29 06:53:14 UTC
Ping? This FTBFS still persists.

I'd suggest, I'd apply my patch such that this bug can be closed.

I don't think this would be a problem to you, because this should not affect your autotool-/upgrading-activities and would take the pressure off from you.

Comment 6 Björn 'besser82' Esser 2013-08-29 07:23:07 UTC
pong!

I'm actually ready to push 2.0.0 (patched Makefiles) with building a so-lib (shipped in sub-pkg "libimgquant").  I just waited on some reply from you, Ralf, on comment #4.

Comment 7 Ralf Corsepius 2013-08-29 12:39:18 UTC
It's your package ... If you feel confident enough about, ... go ahead.

Comment 8 Fedora Update System 2013-09-02 10:58:34 UTC
pngquant-2.0.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.fc19

Comment 9 Fedora Update System 2013-09-02 10:59:02 UTC
pngquant-2.0.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.fc18

Comment 10 Fedora Update System 2013-09-02 10:59:29 UTC
pngquant-2.0.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.el6

Comment 11 Fedora Update System 2013-09-02 11:00:07 UTC
pngquant-2.0.0-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/pngquant-2.0.0-1.el5

Comment 12 Björn 'besser82' Esser 2013-09-02 11:12:42 UTC
(In reply to Ralf Corsepius from comment #5)
> Ping? This FTBFS still persists.
> 
> I'd suggest, I'd apply my patch such that this bug can be closed.

Previously mentioned updates have been successfuly build on F20 and rawhide, too.  This can be closed now.  :)

Comment 13 Fedora Update System 2013-09-02 23:29:40 UTC
pngquant-2.0.0-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-09-12 02:06:20 UTC
pngquant-2.0.0-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2013-09-23 18:11:40 UTC
pngquant-2.0.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2013-09-23 18:13:02 UTC
pngquant-2.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.