Bug 993892
| Summary: | vym possibly affected by F-20 unversioned docdir change | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
| Component: | vym | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | gwync |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://fedoraproject.org/wiki/Changes/UnversionedDocdirs | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-09 15:59:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 993551 | ||
False positive. (In reply to Jon Ciesla from comment #1) > False positive. Nope, yet again as witnessed by the suggested grep: $ grep -E "(/doc|_docdir|_defaultdocdir).+version" vym.spec qmake-qt4 DOCDIR="%{_docdir}/%{name}-%{version}" PREFIX=%{_prefix} mv %{buildroot}/usr/share/doc/vym-%{version}/vym.pdf . DOCDIR ends up compiled in in mainwindow.cpp (through VYM_DOCDIR): $ grep -rF DOCDIR vym-2.3.19 vym-2.3.19/vym.pro:isEmpty( DOCDIR ) { vym-2.3.19/vym.pro: DOCDIR = $${DATADIR}/doc/packages/vym vym-2.3.19/vym.pro:doc.path = $${DOCDIR} vym-2.3.19/vym.pro:DEFINES += VYM_DOCDIR=\\\"$${DOCDIR}\\\" vym-2.3.19/scripts/getbinaries:DOCDIR=$TMPDIR/tex vym-2.3.19/scripts/getbinaries:cp $DOCDIR/*.pdf $BINDIR vym-2.3.19/mainwindow.cpp: #if defined(VYM_DOCDIR) vym-2.3.19/mainwindow.cpp: searchList << VYM_DOCDIR; Got it, fixed with conditionals. |
vym was identified as a package possibly needing maintainer attention due to the F-20 unversioned doc dir change. The identification is not foolproof, it is basically this grep: grep -E "(/doc|_docdir|_defaultdocdir).+version" *.spec Please review your package and make the appropriate changes, if any. A good starting point is checking the lines output by the above grep for your specfile. For the vast majority of packages, after the changes, the expected outcome is that documentation dirs in /usr/share/doc should no longer contain the package version. More information and tips: https://fedoraproject.org/wiki/Changes/UnversionedDocdirs http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183943 http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183973